time: Deprecate the library in the distribution #18858
Merged
+336
−273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
cc #18585, one less crate to worry about! |
| @@ -135,6 +135,14 @@ impl Duration { | |||
| Duration { secs: secs, nanos: nanos as i32 } | |||
| } | |||
|
|
|||
| /// Runs a closure, returning the duration of time it took to run the | |||
| /// closure. | |||
| pub fn span(f: ||) -> Duration { | |||
There was a problem hiding this comment.
I wouldn't want to block this PR on this but I think it'd be better for span to take a closure that returns T and return a tuple of (Duration, T) to make it more general-purpose. It'd certainly make it easier to avoid the extra mutable variables that are introduced at this function's call sites in this PR.
There was a problem hiding this comment.
Yeah that would definitely help out those use cases, but I figured that it would be slightly odd to have to worry about the tuple afterwards. I think it may be the right way to go though, it seemed to come up more often than I anticipated!
|
As you're saying we'll tweak the interface with unboxed closures anyway, at which point we can make the suggested change. |
alexcrichton
force-pushed
the
remove-time
branch
from
5ed19a0
to
4f63687
Compare
alexcrichton
force-pushed
the
remove-time
branch
from
4f63687
to
a90f44c
Compare
This commit deprecates the entire libtime library in favor of the
externally-provided libtime in the rust-lang organization. Users of the
`libtime` crate as-is today should add this to their Cargo manifests:
[dependencies.time]
git = "https://github.com/rust-lang/time"
To implement this transition, a new function `Duration::span` was added to the
`std::time::Duration` time. This function takes a closure and then returns the
duration of time it took that closure to execute. This interface will likely
improve with `FnOnce` unboxed closures as moving in and out will be a little
easier.
Due to the deprecation of the in-tree crate, this is a:
[breaking-change]
cc rust-lang#18855, some of the conversions in the `src/test/bench` area may have been a
little nicer with that implemented
alexcrichton
force-pushed
the
remove-time
branch
from
a90f44c
to
fcd05ed
Compare
bors
added a commit
that referenced
this pull request
Nov 12, 2014
This commit deprecates the entire libtime library in favor of the
externally-provided libtime in the rust-lang organization. Users of the
`libtime` crate as-is today should add this to their Cargo manifests:
[dependencies.time]
git = "https://github.com/rust-lang/time"
To implement this transition, a new function `Duration::span` was added to the
`std::time::Duration` time. This function takes a closure and then returns the
duration of time it took that closure to execute. This interface will likely
improve with `FnOnce` unboxed closures as moving in and out will be a little
easier.
Due to the deprecation of the in-tree crate, this is a:
[breaking-change]
cc #18855, some of the conversions in the `src/test/bench` area may have been a
little nicer with that implemented
This was referenced Nov 13, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deprecates the entire libtime library in favor of the
externally-provided libtime in the rust-lang organization. Users of the
libtimecrate as-is today should add this to their Cargo manifests:To implement this transition, a new function
Duration::spanwas added to thestd::time::Durationtime. This function takes a closure and then returns theduration of time it took that closure to execute. This interface will likely
improve with
FnOnceunboxed closures as moving in and out will be a littleeasier.
Due to the deprecation of the in-tree crate, this is a:
[breaking-change]
cc #18855, some of the conversions in the
src/test/bencharea may have been alittle nicer with that implemented