Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::time::duration::Duration::span() is backwards #18925

Closed
ben0x539 opened this issue Nov 13, 2014 · 2 comments · Fixed by #18926
Closed

std::time::duration::Duration::span() is backwards #18925

ben0x539 opened this issue Nov 13, 2014 · 2 comments · Fixed by #18926

Comments

@ben0x539
Copy link
Contributor

Duration::span() returns negative durations!

cc #18858
@alexcrichton
Copy link
Member

Oh dear, I'm so sorry! I'll fix pronto

@alexcrichton alexcrichton mentioned this issue Nov 13, 2014
Merged
@ben0x539
Copy link
Contributor Author

Oh, don't worry about "pronto". By current reckoning you'll get the fix in with less than zero delay, I couldn't ask for more than that!

alexcrichton added a commit to alexcrichton/rust that referenced this issue Nov 13, 2014
@alexcrichton
std: Fix the return value of Duration::span
8771394 
The subtraction was erroneously backwards, returning negative durations!

Closes rust-lang#18925
bors added a commit that referenced this issue Nov 13, 2014
@bors
auto merge of #18926 : alexcrichton/rust/issue-18925, r=huonw
b1c84d6 
The subtraction was erroneously backwards, returning negative durations!

Closes #18925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

std: Fix the return value of Duration::span alexcrichton/rust
2 participants
@ben0x539 @alexcrichton