Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate some FIXME(lcnr) comments #124918

Merged
merged 6 commits into from
May 10, 2024
Merged

Eliminate some FIXME(lcnr) comments #124918

merged 6 commits into from
May 10, 2024
+12 −51

Commits on May 9, 2024

  1. Correct a comment. 

    I tried simplifying `RegionCtxt`, which led me to finding that the
fields are printed in `sccs_info`.
    @nnethercote
    nnethercote committed May 9, 2024
    Configuration menu
    Copy the full SHA
    609b9a6 View commit details
    Browse the repository at this point in the history

  2. Fix up DescriptionCtx::new. 

    The comment mentions that `ReBound` and `ReVar` aren't expected here.
Experimentation with the full test suite indicates this is true, and
that `ReErased` also doesn't occur. So the commit introduces `bug!` for
those cases. (If any of them show up later on, at least we'll have a
test case.)

The commit also remove the first sentence in the comment.
`RePlaceholder` is now handled in the match arm above this comment and
nothing is printed for it, so that sentence is just wrong. Furthermore,
issue rust-lang#13998 was closed some time ago.
    @nnethercote
    nnethercote committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d6c63bd View commit details
    Browse the repository at this point in the history

  3. Fix out-of-date comment. 

    The type name has changed.
    @nnethercote
    nnethercote committed May 9, 2024
    Configuration menu
    Copy the full SHA
    5b5dd1b View commit details
    Browse the repository at this point in the history

  4. Remove TyCtxt::try_normalize_erasing_late_bound_regions. 

    It's unused.
    @nnethercote
    nnethercote committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d13612b View commit details
    Browse the repository at this point in the history

  5. Remove out-of-date comment. 

    The use of `Binder` was removed in the recent rust-lang#123900, but the comment
wasn't removed at the same time.
    @nnethercote
    nnethercote committed May 9, 2024
    Configuration menu
    Copy the full SHA
    24445d3 View commit details
    Browse the repository at this point in the history

  6. De-tuple two vtable_trait_first_method_offset args. 

    Thus eliminating a `FIXME` comment.
    @nnethercote
    nnethercote committed May 9, 2024
    Configuration menu
    Copy the full SHA
    df6f713 View commit details
    Browse the repository at this point in the history