Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate some FIXME(lcnr) comments #124918

Merged
merged 6 commits into from May 10, 2024
Merged

Eliminate some FIXME(lcnr) comments #124918

merged 6 commits into from May 10, 2024

Conversation

nnethercote
Copy link
Contributor

In some cases this involved changing code. In some cases the comment was able to removed or replaced.

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 9, 2024
@nnethercote
Correct a comment.
609b9a6 
I tried simplifying `RegionCtxt`, which led me to finding that the
fields are printed in `sccs_info`.
@nnethercote
Fix up DescriptionCtx::new.
d6c63bd 
The comment mentions that `ReBound` and `ReVar` aren't expected here.
Experimentation with the full test suite indicates this is true, and
that `ReErased` also doesn't occur. So the commit introduces `bug!` for
those cases. (If any of them show up later on, at least we'll have a
test case.)

The commit also remove the first sentence in the comment.
`RePlaceholder` is now handled in the match arm above this comment and
nothing is printed for it, so that sentence is just wrong. Furthermore,
issue rust-lang#13998 was closed some time ago.
lcnr
lcnr reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after nits

compiler/rustc_infer/src/infer/mod.rs Outdated Show resolved Hide resolved
@nnethercote
Fix out-of-date comment.
5b5dd1b 
The type name has changed.
@nnethercote
Remove TyCtxt::try_normalize_erasing_late_bound_regions.
d13612b 
It's unused.
@nnethercote
Remove out-of-date comment.
24445d3 
The use of `Binder` was removed in the recent rust-lang#123900, but the comment
wasn't removed at the same time.
@nnethercote
De-tuple two vtable_trait_first_method_offset args.
df6f713 
Thus eliminating a `FIXME` comment.
@nnethercote
Copy link
Contributor Author

nnethercote commented May 10, 2024 •
edited

I addressed the comment.

@bors r=lcnr rollup

@bors
Copy link
Contributor

bors commented May 10, 2024

📌 Commit df6f713 has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2024
@nnethercote
Copy link
Contributor Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2024
@nnethercote
Copy link
Contributor Author

@bors r=lcnr

@bors
Copy link
Contributor

bors commented May 10, 2024

📌 Commit df6f713 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 10, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 10, 2024
@matthiaskrgr
Rollup merge of rust-lang#124918 - nnethercote:FIXME-lcnr, r=lcnr
cf4ca02 
Eliminate some `FIXME(lcnr)` comments

In some cases this involved changing code. In some cases the comment was able to removed or replaced.

r? `@lcnr`
@matthiaskrgr matthiaskrgr mentioned this pull request May 10, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2024
@bors
Auto merge of rust-lang#124960 - matthiaskrgr:rollup-xrohkox, r=matth…
ad31ee3 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#124551 (Add benchmarks for `impl Debug for str`)
 - rust-lang#124914 (Remove `#[macro_use] extern crate rustc middle` from numerous crates)
 - rust-lang#124915 (`rustc_target` cleanups)
 - rust-lang#124918 (Eliminate some `FIXME(lcnr)` comments)
 - rust-lang#124927 (opt-dist: use xz2 instead of xz crate)
 - rust-lang#124936 (analyse visitor: build proof tree in probe)
 - rust-lang#124943 (always use `GenericArgsRef`)

Failed merges:

 - rust-lang#124955 (Use fewer origins when creating type variables.)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request May 10, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2024
@bors
Auto merge of rust-lang#124961 - matthiaskrgr:rollup-1jj65p6, r=matth…
f7b1501 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#124551 (Add benchmarks for `impl Debug for str`)
 - rust-lang#124915 (`rustc_target` cleanups)
 - rust-lang#124918 (Eliminate some `FIXME(lcnr)` comments)
 - rust-lang#124927 (opt-dist: use xz2 instead of xz crate)
 - rust-lang#124936 (analyse visitor: build proof tree in probe)
 - rust-lang#124943 (always use `GenericArgsRef`)
 - rust-lang#124955 (Use fewer origins when creating type variables.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7e4f608 into rust-lang:master May 10, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 10, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2024
@rust-timer
Unrolled build for rust-lang#124918
482ec7f 
Rollup merge of rust-lang#124918 - nnethercote:FIXME-lcnr, r=lcnr

Eliminate some `FIXME(lcnr)` comments

In some cases this involved changing code. In some cases the comment was able to removed or replaced.

r? ``@lcnr``
@matthiaskrgr matthiaskrgr mentioned this pull request May 10, 2024
Open
@nnethercote nnethercote deleted the FIXME-lcnr branch May 12, 2024 21:51
nnethercote added a commit to nnethercote/rust that referenced this pull request May 12, 2024
@nnethercote
Fix rust-lang#124973.
a4ab375 
PR rust-lang#124918 made this path abort. The added test, from fuzzing,
identified that it is reachable.
@nnethercote nnethercote mentioned this pull request May 12, 2024
Open
flip1995 pushed a commit to flip1995/rust that referenced this pull request May 17, 2024
@bors
Auto merge of rust-lang#124961 - matthiaskrgr:rollup-1jj65p6, r=matth…
ff931a7 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#124551 (Add benchmarks for `impl Debug for str`)
 - rust-lang#124915 (`rustc_target` cleanups)
 - rust-lang#124918 (Eliminate some `FIXME(lcnr)` comments)
 - rust-lang#124927 (opt-dist: use xz2 instead of xz crate)
 - rust-lang#124936 (analyse visitor: build proof tree in probe)
 - rust-lang#124943 (always use `GenericArgsRef`)
 - rust-lang#124955 (Use fewer origins when creating type variables.)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcol mcol mcol left review comments

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nnethercote @bors @mcol @lcnr @rustbot