Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish: Move all features to feature2 if new syntax is used #6168

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Mar 9, 2023

Resolves #6135

@Turbo87 Turbo87 added C-bug 🐞 Category: unintended, undesired behavior A-backend ⚙️ labels Mar 9, 2023
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

This may change the error message users get when running cargo update in versions 1.19 to 1.51. There are different scenarios:

  • The update selects a version with the new syntax, but did not need any of the features using the new syntax: Previously would get an error parsing the features.
  • The update selects a version with the new syntax, and it needed a feature with the new syntax: Previously would get a failed to select a version (after 1.26? saying it "does not have these features").

With this change, I think it will always be the second case.

@bors
Copy link
Contributor

bors commented Apr 14, 2023

☔ The latest upstream changes (presumably 8ca037e) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

features2 in index broke cargo backward compatibility
3 participants