Add FixFeature2 background worker job
#6169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This job "fixes" the `features2` entries by moving all `features` into `feature2` if `feature2` already has content. This should avoid a mismatch of `features` pointing to `features2` for older cargo versions.
|
It looks like this would affect 2049 files in the index, which is an uncomfortably large number. It would be good to get some data on how long that will affect the index update, particularly with a cached copy that hasn't been updated in a while (like sometime between Jan 13 and Feb 1 to be after the normalization commit). |
|
☔ The latest upstream changes (presumably #5066) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This job "fixes" the
features2entries by moving allfeaturesintofeature2iffeature2already has content. This should avoid a mismatch offeaturespointing tofeatures2for older cargo versions.Related:
featurestofeature2if new syntax is used #6168