-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Count combinations with replacement #737
Merged
bors
merged 8 commits into
rust-itertools:master
from
Philippe-Cholet:count_combinations_with_replacement
Sep 4, 2023
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
630f78d
Remaining combinations with replacement
Philippe-Cholet c9b2fdb
`CombinationsWithReplacement::size_hint`
Philippe-Cholet b9bc9e5
`CombinationsWithReplacement::count`
Philippe-Cholet a163451
Test `combinations_with_replacement` counts
Philippe-Cholet 9cb3543
Fix debug type name
Philippe-Cholet dd0e66c
`remaining_for`: add "stars and bars" explanation
Philippe-Cholet c13ee58
`remaining_for`: handle `n + k - 1` overflowing
Philippe-Cholet 8ce17a9
`remaining_for`: copy/update previous explanation
Philippe-Cholet File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you that this is correct, but I have a hard time comprehending this without comments. Is it the "stars and sticks" thing that leads to
binomial(n+k-1, k)
?Could you comment the loop similar to what we did in the other cases?
In addition: Could
n+k
overflow? And if so, shouldn't we returnNone
here instead ofpanic
king?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose the expression "stars and bars" from wikipedia, expression I did not know. I added a comment.
Good catch
n+k
overflowing, handled.And I copied/updated the previous comment about the loop.