Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count combinations with replacement #737

Merged
merged 8 commits into from
Sep 4, 2023
Merged

Count combinations with replacement #737

merged 8 commits into from
Sep 4, 2023

Commits on Aug 26, 2023

  1. Remaining combinations with replacement 

    Only two differences with combinations *without* replacement:
- this `count` instead of `checked_binomial` ;
- `k` can be bigger than `n`.
    @Philippe-Cholet
    Philippe-Cholet committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    630f78d View commit details
    Browse the repository at this point in the history

  2. CombinationsWithReplacement::size_hint

    @Philippe-Cholet
    Philippe-Cholet committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    c9b2fdb View commit details
    Browse the repository at this point in the history

  3. CombinationsWithReplacement::count

    @Philippe-Cholet
    Philippe-Cholet committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    b9bc9e5 View commit details
    Browse the repository at this point in the history

  4. Test combinations_with_replacement counts 

    For a fast test: `n` and `k` are only up to 7.
    @Philippe-Cholet
    Philippe-Cholet committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    a163451 View commit details
    Browse the repository at this point in the history

  5. Fix debug type name

    @Philippe-Cholet
    Philippe-Cholet committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    9cb3543 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. remaining_for: add "stars and bars" explanation

    @Philippe-Cholet
    Philippe-Cholet committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    dd0e66c View commit details
    Browse the repository at this point in the history

  2. remaining_for: handle n + k - 1 overflowing 

    Note that `n + k` might overflow but maybe `n + k - 1` should not.
    @Philippe-Cholet
    Philippe-Cholet committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    c13ee58 View commit details
    Browse the repository at this point in the history

  3. remaining_for: copy/update previous explanation

    @Philippe-Cholet
    Philippe-Cholet committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    8ce17a9 View commit details
    Browse the repository at this point in the history