Fixes wrong error message when running as root in sandbox mode #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running as root the error reported is misleading: There are no available ports between 8000 and 9000 for debugging This commit fixes this and reports the proper (new) error RunningAsRootWithoutNoSandbox: You need to set the sandbox(false) option when running as root
This was referenced Aug 1, 2023
|
Looks good, can you please make sure it passes |
|
@Billy-Sheppard done even though the cargo check complaint was not caused by my changes and happens in Thanks! |
|
Ah! My mistake, thank you - I'm currently working on a fix for some of these issues. Thanks for your PR! |
pull bot
pushed a commit
to mirsella/rust-headless-chrome
that referenced
this pull request
Oct 9, 2023
…headless-chrome#406) * Fixes wrong error message when running as root in sandbox mode When running as root the error reported is misleading: There are no available ports between 8000 and 9000 for debugging This commit fixes this and reports the proper (new) error RunningAsRootWithoutNoSandbox: You need to set the sandbox(false) option when running as root * Fixes cargo check error for a mut where not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running as root the error reported is misleading:
This commit fixes this and reports the proper (new) error
RunningAsRootWithoutNoSandbox: