Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable-sandbox option #10

Merged
merged 1 commit into from Oct 17, 2023
Merged

Add disable-sandbox option #10

merged 1 commit into from Oct 17, 2023

Conversation

randommm
Copy link
Contributor

To run on Docker, it's necessary to disable Chrome sandbox option, so here's a PR that exposes this option to both the API and the command line.

See rust-headless-chrome/rust-headless-chrome#406

Copy link
Owner

@ilaborie ilaborie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@ilaborie ilaborie merged commit d4fa912 into ilaborie:main Oct 17, 2023
3 of 4 checks passed
@ilaborie
Copy link
Owner

I've released a v0.7 version with your contribution

@randommm
Copy link
Contributor Author

Thanks! I've just updated my dependencies to include it randommm/rust-slack-app-html-to-pdf@16fd994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants