Fix an infinite loop for Style/RaiseArgs
with EnforcedStyle: compact
when passing more than 2 arguments to raise
#12774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following test causes the loop:
rubocop/spec/rubocop/cop/style/raise_args_spec.rb
Lines 130 to 140 in 5ee786d
This changes
expect_no_corrections
to always raise if there are correctors. In this case the corrector replaced nothing, resulting in the same cop being invocted again for the same reason.Undoing the cop change while keeping the assertion change will produce a failure. The source assertion is left in because it produces nice diffs if there are actually changes.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.