Merge pull request #12770 from Earlopain/fix-an-error-for-lint-redund…

…ant-with-index Fix an error for `Lint/RedundantWithIndex` when there is no receiver
rubocop · Mar 10, 2024 · 5ee786d · 5ee786d
2 parents 1281bf0 + 42884ee
commit 5ee786d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/changelog/fix_an_error_for_lint_redundant_with_index.md b/changelog/fix_an_error_for_lint_redundant_with_index.md
@@ -0,0 +1 @@
+* [#12770](https://github.com/rubocop/rubocop/pull/12770): Fix an error for `Lint/RedundantWithIndex` when the method has no receiver. ([@earlopain][])
diff --git a/lib/rubocop/cop/lint/redundant_with_index.rb b/lib/rubocop/cop/lint/redundant_with_index.rb
@@ -34,6 +34,7 @@ class RedundantWithIndex < Base
         MSG_WITH_INDEX = 'Remove redundant `with_index`.'
 
         def on_block(node)
+          return unless node.receiver
           return unless (send = redundant_with_index?(node))
 
           range = with_index_range(send)

diff --git a/spec/rubocop/cop/lint/redundant_with_index_spec.rb b/spec/rubocop/cop/lint/redundant_with_index_spec.rb
@@ -100,5 +100,13 @@
     it 'accepts an index is used as a numblock argument' do
       expect_no_offenses('ary.each_with_index { _1; _2 }')
     end
+
+    it 'accepts with_index without receiver with a block' do
+      expect_no_offenses('with_index { |v| v }')
+    end
+
+    it 'accepts with_index without receiver with a numblock' do
+      expect_no_offenses('with_index { _1 }')
+    end
   end
 end