[Fix #12547] User experience for infinite loop detected #12655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the latest version in case of 'Infinite loop detected' error.
Hiroto-Iizuka
force-pushed
the
User-experience-for-Infinite_loop_detected
branch
from
3f7880a
to
60b24d1
Compare
Hiroto-Iizuka
changed the title
Hiroto-Iizuka
changed the title
andyw8
reviewed
Jan 30, 2024
lib/rubocop/runner.rb
Outdated
| @@ -20,6 +20,9 @@ def initialize(path, offenses_by_iteration, loop_start: -1) | |||
| message = 'Infinite loop detected' | |||
| message += " in #{path}" if path | |||
| message += " and caused by #{root_cause}" if root_cause | |||
| message += ' \n\nPlease update to the latest RuboCop version if not already in use,' | |||
| message += ' \nand report a bug if the issue still occurs on this version.' | |||
| message += ' \n\nPlease check the latest version at "https://rubygems.org/gems/rubocop"' | |||
There was a problem hiding this comment.
I'd suggest dropping the quotes around the URL.
andyw8
reviewed
Jan 30, 2024
lib/rubocop/runner.rb
Outdated
| @@ -20,6 +20,9 @@ def initialize(path, offenses_by_iteration, loop_start: -1) | |||
| message = 'Infinite loop detected' | |||
| message += " in #{path}" if path | |||
| message += " and caused by #{root_cause}" if root_cause | |||
| message += ' \n\nPlease update to the latest RuboCop version if not already in use,' | |||
There was a problem hiding this comment.
It might be problematic to have newlines here, especially if other programs need to consume the output. The maintainers can probably say more.
There was a problem hiding this comment.
Thanks for the review!
I rewrote it in a form without line breaks.
|
Nice! |
Hiroto-Iizuka
force-pushed
the
User-experience-for-Infinite_loop_detected
branch
from
b83e715
to
9549f0f
Compare
|
@koic any thoughts? |
|
I think that's a good small improvement. Sorry for taking so long to merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12547
This pull request includes the following:
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.