Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User experience for "Infinite loop detected" #12547

Closed
andyw8 opened this issue Dec 15, 2023 · 4 comments
Closed

User experience for "Infinite loop detected" #12547

andyw8 opened this issue Dec 15, 2023 · 4 comments
Labels
enhancement good first issue Easy task, suitable for newcomers to the project

Comments

@andyw8
Copy link
Contributor

andyw8 commented Dec 15, 2023

If a user encounters an "Infinite loop detected" error, then I think it makes sense for RuboCop to provide some actionable advice, e.g.:

  1. Suggest to the user to update to the latest RuboCop version, if not already in use.
  2. Suggest to report a bug if it still occurs on the latest version.
@jonas054 jonas054 added enhancement good first issue Easy task, suitable for newcomers to the project labels Jan 1, 2024
@Hiroto-Iizuka
Copy link
Contributor

@andyw8

I would like to know more about this issue.

Should I simply add that comment?
Or are you saying that I should specify the current version of Rubocop and post the comment?

@andyw8
Copy link
Contributor Author

andyw8 commented Jan 24, 2024

Displaying the latest version would require a network call, which may not be available, so showing a link to https://rubygems.org/gems/rubocop may be the best option.

@Hiroto-Iizuka
Copy link
Contributor

@andyw8

Thank you very much.
This is my first time so I am not sure but I will give it a try.

Hiroto-Iizuka added a commit to Hiroto-Iizuka/rubocop that referenced this issue Jan 26, 2024
@Hiroto-Iizuka
Fix rubocop#12547 : Suggest to the user to update to the latest RuboC…
650df2e 
…op version when 'Infinite loop detected' error occurs
Hiroto-Iizuka added a commit to Hiroto-Iizuka/rubocop that referenced this issue Jan 26, 2024
@Hiroto-Iizuka
Fix rubocop#12547 : rspec fix
3f7880a
Hiroto-Iizuka added a commit to Hiroto-Iizuka/rubocop that referenced this issue Jan 27, 2024
@Hiroto-Iizuka
Fix rubocop#12547 : Added comment with suggestion to bring Rubocop up…
7ad8f07 
… to the latest version in case of 'Infinite loop detected' error.
Hiroto-Iizuka added a commit to Hiroto-Iizuka/rubocop that referenced this issue Jan 27, 2024
@Hiroto-Iizuka
Fix rubocop#12547 : fix rspec
60b24d1
Hiroto-Iizuka added a commit to Hiroto-Iizuka/rubocop that referenced this issue Jan 27, 2024
@Hiroto-Iizuka
Fix rubocop#12547 : add a changelog
e6d9f79
@Hiroto-Iizuka Hiroto-Iizuka mentioned this issue Jan 27, 2024
Merged
8 tasks
@Hiroto-Iizuka
Copy link
Contributor

I tried this issue.
Waiting for confirmation from Rubocop maintainers.

#12655

Hiroto-Iizuka added a commit to Hiroto-Iizuka/rubocop that referenced this issue Jan 30, 2024
@Hiroto-Iizuka
Fix rubocop#12547 : drop the quotes around the URL
9549f0f
Hiroto-Iizuka added a commit to Hiroto-Iizuka/rubocop that referenced this issue Feb 6, 2024
@Hiroto-Iizuka
Fix rubocop#12547 : fix text
94854a6
@bbatsov bbatsov closed this as completed in de82525 Apr 8, 2024
bbatsov pushed a commit that referenced this issue Apr 8, 2024
@Hiroto-Iizuka @bbatsov
Fix #12547 : fix rspec
efc9bd2
bbatsov pushed a commit that referenced this issue Apr 8, 2024
@Hiroto-Iizuka @bbatsov
Fix #12547 : add a changelog
d00285c
bbatsov pushed a commit that referenced this issue Apr 8, 2024
@Hiroto-Iizuka @bbatsov
Fix #12547 : drop the quotes around the URL
7d42542
bbatsov pushed a commit that referenced this issue Apr 8, 2024
@Hiroto-Iizuka @bbatsov
Fix #12547 : fix text
ebcc72a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Easy task, suitable for newcomers to the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andyw8 @jonas054 @Hiroto-Iizuka