Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Style/RaiseArgs as unsafe #12637

Merged
merged 1 commit into from Jan 24, 2024

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented Jan 18, 2024

.exception and .new behave roughly the same way, but I don't think they are guaranteed to always be so.

What do you think?


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@bbatsov bbatsov merged commit fbf41c6 into rubocop:master Jan 24, 2024
33 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Jan 24, 2024

Fine by me.

@r7kamura r7kamura deleted the style-raise-args-safety branch January 24, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants