Mark Style/RaiseArgs as unsafe

rubocop · Jan 24, 2024 · fbf41c6 · fbf41c6
1 parent edb56c9
commit fbf41c6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/changelog/change_mark_style_raise_args_as_unsafe.md b/changelog/change_mark_style_raise_args_as_unsafe.md
@@ -0,0 +1 @@
+* [#12637](https://github.com/rubocop/rubocop/pull/12637): Mark `Style/RaiseArgs` as unsafe. ([@r7kamura][])
diff --git a/config/default.yml b/config/default.yml
@@ -4835,8 +4835,9 @@ Style/RaiseArgs:
   Description: 'Checks the arguments passed to raise/fail.'
   StyleGuide: '#exception-class-messages'
   Enabled: true
+  Safe: false
   VersionAdded: '0.14'
-  VersionChanged: '1.2'
+  VersionChanged: '<<next>>'
   EnforcedStyle: exploded
   SupportedStyles:
     - compact # raise Exception.new(msg)

diff --git a/lib/rubocop/cop/style/raise_args.rb b/lib/rubocop/cop/style/raise_args.rb
@@ -16,6 +16,9 @@ module Style
       # The exploded style has an `AllowedCompactTypes` configuration
       # option that takes an Array of exception name Strings.
       #
+      # @safety
+      #   This cop is unsafe because `raise Foo` calls `Foo.exception`, not `Foo.new`.
+      #
       # @example EnforcedStyle: exploded (default)
       #   # bad
       #   raise StandardError.new('message')