Fix an error for Style/RedundantDoubleSplatHashBraces
#12326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_an_error_for_style_redundant_double_splat_hash_braces
branch
from
521674c
to
3aec751
Compare
Fixes rubocop#12275 (comment). This PR fixes an error for `Style/RedundantDoubleSplatHashBraces` when method call for parenthesized no hash double double splat.
koic
force-pushed
the
fix_an_error_for_style_redundant_double_splat_hash_braces
branch
from
3aec751
to
930755c
Compare
koic
deleted the
fix_an_error_for_style_redundant_double_splat_hash_braces
branch
|
Curious if there is a release planned with this? Or we are waiting to have more changes? |
|
@mathieujobin I haven't decided on when to cut the next release and I'll probably wait for more changes to accumulate to warrant a release. Likely this will happen in a week or two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12275 (comment).
This PR fixes an error for
Style/RedundantDoubleSplatHashBraceswhen method call for parenthesized no hash double double splat.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.