Fix an error for Style/RedundantDoubleSplatHashBraces

Fixes #12275 (comment). This PR fixes an error for `Style/RedundantDoubleSplatHashBraces` when method call for parenthesized no hash double double splat.
rubocop · Oct 31, 2023 · 930755c · 930755c
1 parent f981a1a
commit 930755c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/changelog/fix_an_error_for_style_redundant_double_splat_hash_braces.md b/changelog/fix_an_error_for_style_redundant_double_splat_hash_braces.md
@@ -0,0 +1 @@
+* [#12326](https://github.com/rubocop/rubocop/pull/12326): Fix an error for `Style/RedundantDoubleSplatHashBraces` when method call for parenthesized no hash double double splat. ([@koic][])
diff --git a/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb b/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb
@@ -25,20 +25,20 @@ class RedundantDoubleSplatHashBraces < Base
         MSG = 'Remove the redundant double splat and braces, use keyword arguments directly.'
         MERGE_METHODS = %i[merge merge!].freeze
 
-        # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
         def on_hash(node)
           return if node.pairs.empty? || node.pairs.any?(&:hash_rocket?)
           return unless (parent = node.parent)
           return unless parent.call_type? || parent.kwsplat_type?
           return unless mergeable?(parent)
           return unless (kwsplat = node.each_ancestor(:kwsplat).first)
-          return if allowed_double_splat_receiver?(kwsplat)
+          return if !node.braces? || allowed_double_splat_receiver?(kwsplat)
 
           add_offense(kwsplat) do |corrector|
             autocorrect(corrector, node, kwsplat)
           end
         end
-        # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 
         private
 

diff --git a/spec/rubocop/cop/style/redundant_double_splat_hash_braces_spec.rb b/spec/rubocop/cop/style/redundant_double_splat_hash_braces_spec.rb
@@ -165,6 +165,12 @@
     RUBY
   end
 
+  it 'does not register an offense when method call for parenthesized no hash double double splat' do
+    expect_no_offenses(<<~RUBY)
+      do_something(**(options.merge(foo: bar)))
+    RUBY
+  end
+
   it 'does not register an offense when using empty double splat hash braces arguments' do
     expect_no_offenses(<<~RUBY)
       do_something(**{})