Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Style/SingleLineDoEndBlock #12283

Merged

Commits on Oct 14, 2023

  1. Fix an error for Style/SingleLineDoEndBlock

    This PR fixes the following error for `Style/SingleLineDoEndBlock`
    when using single line `do`...`end` with no body
    
    ```console
    $ echo 'foo do end' | bunlde exec rubocop --stdin test.rb -d --only Style/SingleLineDoEndBlock
    (snip)
    
    An error occurred while Style/SingleLineDoEndBlock cop was inspecting
    /Users/koic/src/github.com/rubocop/rubocop/test.rb:1:0.
    Expected a Parser::Source::Range, Comment or RuboCop::AST::Node, got NilClass
    /Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/corrector.rb:111:in `to_range'
    /Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/corrector.rb:120:in `check_range_validity'
    /Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/parser-3.2.2.4/
    lib/parser/source/tree_rewriter.rb:398:in `combine'
    /Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/parser-3.2.2.4/
    lib/parser/source/tree_rewriter.rb:207:in `wrap'
    /Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/parser-3.2.2.4/
    lib/parser/source/tree_rewriter.rb:243:in `insert_after'
    /Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/single_line_do_end_block.rb:45:in `block in on_block'
    ```
    koic committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    1e5bd7e View commit details
    Browse the repository at this point in the history