Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Style/SingleLineDoEndBlock #12283

Merged

Conversation

koic
Copy link
Member

@koic koic commented Oct 14, 2023

This PR fixes the following error for Style/SingleLineDoEndBlock when using single line do...end with no body

$ echo 'foo do end' | bunlde exec rubocop --stdin test.rb -d --only Style/SingleLineDoEndBlock
(snip)

An error occurred while Style/SingleLineDoEndBlock cop was inspecting
/Users/koic/src/github.com/rubocop/rubocop/test.rb:1:0.
Expected a Parser::Source::Range, Comment or RuboCop::AST::Node, got NilClass
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/corrector.rb:111:in `to_range'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/corrector.rb:120:in `check_range_validity'
/Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/parser-3.2.2.4/
lib/parser/source/tree_rewriter.rb:398:in `combine'
/Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/parser-3.2.2.4/
lib/parser/source/tree_rewriter.rb:207:in `wrap'
/Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/parser-3.2.2.4/
lib/parser/source/tree_rewriter.rb:243:in `insert_after'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/single_line_do_end_block.rb:45:in `block in on_block'

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following error for `Style/SingleLineDoEndBlock`
when using single line `do`...`end` with no body

```console
$ echo 'foo do end' | bunlde exec rubocop --stdin test.rb -d --only Style/SingleLineDoEndBlock
(snip)

An error occurred while Style/SingleLineDoEndBlock cop was inspecting
/Users/koic/src/github.com/rubocop/rubocop/test.rb:1:0.
Expected a Parser::Source::Range, Comment or RuboCop::AST::Node, got NilClass
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/corrector.rb:111:in `to_range'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/corrector.rb:120:in `check_range_validity'
/Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/parser-3.2.2.4/
lib/parser/source/tree_rewriter.rb:398:in `combine'
/Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/parser-3.2.2.4/
lib/parser/source/tree_rewriter.rb:207:in `wrap'
/Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/parser-3.2.2.4/
lib/parser/source/tree_rewriter.rb:243:in `insert_after'
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/single_line_do_end_block.rb:45:in `block in on_block'
```
@koic koic merged commit affbe3b into rubocop:master Oct 15, 2023
28 checks passed
@koic koic deleted the fix_an_error_for_style_single_line_do_end_block branch October 15, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant