Lint/LiteralInInterpolation: Accept an empty string literal interpolated in %W[]/%I[] #12253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knu
force-pushed
the
accept_empty_string_literal_interpolated_in_words_literal
branch
from
c0c0179
to
6b96c10
Compare
knu
changed the title
…l interpolated in %W[]/%I[]
An empty string in those words literals is significant and must not be expanded.
e.g.
```ruby
system(*%W[git commit -m #{""} file])
```
knu
force-pushed
the
accept_empty_string_literal_interpolated_in_words_literal
branch
from
6b96c10
to
bc1b6a8
Compare
|
Thanks! |
knu
deleted the
accept_empty_string_literal_interpolated_in_words_literal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty string in those words literals is significant and should not be expanded.
e.g.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.