Merge pull request #12253 from knu/accept_empty_string_literal_interp…

…olated_in_words_literal Lint/LiteralInInterpolation: Accept an empty string literal interpolated in %W[]/%I[]
rubocop · Oct 10, 2023 · 11d412f · 11d412f
2 parents ece1a95 + bc1b6a8
commit 11d412f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/changelog/fix_accept_empty_string_literal_interpolated_in_words_literal.md b/changelog/fix_accept_empty_string_literal_interpolated_in_words_literal.md
@@ -0,0 +1 @@
+* [#12253](https://github.com/rubocop/rubocop/pull/12253): Fix `Lint/LiteralInInterpolation` to accept an empty string literal interpolated in words literal. ([@knu][])
diff --git a/lib/rubocop/cop/lint/literal_in_interpolation.rb b/lib/rubocop/cop/lint/literal_in_interpolation.rb
@@ -34,7 +34,7 @@ def on_interpolation(begin_node)
           # interpolation should not be removed if the expanded value
           # contains a space character.
           expanded_value = autocorrected_value(final_node)
-          return if in_array_percent_literal?(begin_node) && /\s/.match?(expanded_value)
+          return if in_array_percent_literal?(begin_node) && /\s|\A\z/.match?(expanded_value)
 
           add_offense(final_node) do |corrector|
             return if final_node.dstr_type? # nested, fixed in next iteration

diff --git a/spec/rubocop/cop/lint/literal_in_interpolation_spec.rb b/spec/rubocop/cop/lint/literal_in_interpolation_spec.rb
@@ -206,6 +206,12 @@
       RUBY
     end
 
+    it "accepts interpolation of an empty string literal in #{prefix}[]" do
+      expect_no_offenses(<<~RUBY)
+        #{prefix}[\#{""} is significant]
+      RUBY
+    end
+
     it "accepts interpolation of a symbol literal with space in #{prefix}[]" do
       expect_no_offenses(<<~RUBY)
         #{prefix}[\#{:"this interpolation"} is significant]