Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for Style/SymbolArray #12120

Merged

Conversation

koic
Copy link
Member

@koic koic commented Aug 14, 2023

This PR fixes false positives for Style/SymbolArray when %i array containing unescaped [, ], (, or ).

I noticed the following false positive in the RuboCop AST repository:

$ cd path/to/rubocop-ast
$ bundle exec rubocop --only Style/SymbolArray
(snip)

spec/rubocop/ast/node_pattern/lexer_spec.rb:36:9: C: [Correctable] Style/SymbolArray:
Use [:'(', :array, :sym, :'$', :int, :+, :x, :')'] for an array of symbols.
        %i[( array sym $ int + x )]
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^

163 files inspected, 1 offense detected, 1 offense autocorrectable

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes false positives for `Style/SymbolArray`
when `%i` array containing unescaped `[`, `]`, `(`, or `)`.

I noticed the following false positive in the RuboCop AST repository:

```console
$ cd path/to/rubocop-ast
$ bundle exec rubocop --only Style/SymbolArray
(snip)

spec/rubocop/ast/node_pattern/lexer_spec.rb:36:9: C: [Correctable] Style/SymbolArray:
Use [:'(', :array, :sym, :'$', :int, :+, :x, :')'] for an array of symbols.
        %i[( array sym $ int + x )]
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^

163 files inspected, 1 offense detected, 1 offense autocorrectable
```
@koic koic force-pushed the fix_a_false_positive_for_style_symbol_array branch from fcd613c to 89eb905 Compare August 14, 2023 16:27
@koic koic changed the title Fix a false positive for Style/SymbolArray Fix false positives for Style/SymbolArray Aug 14, 2023
@koic koic merged commit 9a143e6 into rubocop:master Aug 15, 2023
28 checks passed
@koic koic deleted the fix_a_false_positive_for_style_symbol_array branch August 15, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant