Merge pull request #12120 from koic/fix_a_false_positive_for_style_sy…

…mbol_array

Fix false positives for `Style/SymbolArray`

changelog/fix_false_positives_for_style_symbol_array.md

@@ -0,0 +1 @@
+* [#12119](https://github.com/rubocop/rubocop/pull/12119): Fix false positives for `Style/SymbolArray` when `%i` array containing unescaped `[`, `]`, `(`, or `)`. ([@koic][])

lib/rubocop/cop/style/symbol_array.rb

@@ -69,6 +69,8 @@ def on_array(node)
 
         def complex_content?(node)
           node.children.any? do |sym|
+            return false if DELIMITERS.include?(sym.source)
+
             content = *sym
             content = content.map { |c| c.is_a?(AST::Node) ? c.source : c }.join
             content_without_delimiter_pairs = content.gsub(/(\[[^\s\[\]]*\])|(\([^\s\(\)]*\))/, '')

spec/rubocop/cop/style/symbol_array_spec.rb

@@ -138,7 +138,7 @@
       expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
     end
 
-    it 'registers an offense for a %i array containing [ ]' do
+    it 'registers an offense for a %i array containing escaped [ ]' do
       expect_offense(<<~'RUBY')
         %i[one \[ \] two]
         ^^^^^^^^^^^^^^^^^ Use `[:one, :'[', :']', :two]` for an array of symbols.
@@ -149,6 +149,12 @@
       RUBY
     end
 
+    it 'does not register an offense for a %i array containing unescaped [ ]' do
+      expect_no_offenses(<<~RUBY)
+        %i(one [ ] two)
+      RUBY
+    end
+
     it 'registers an offense for a %i array containing whitespace between brackets' do
       expect_offense(<<~'RUBY')
         %i[one two \[three\ four\ five\]]
@@ -171,7 +177,7 @@
       RUBY
     end
 
-    it 'registers an offense for a %i array containing ( )' do
+    it 'registers an offense for a %i array containing escaped ( )' do
       expect_offense(<<~'RUBY')
         %i(one \( \) two)
         ^^^^^^^^^^^^^^^^^ Use `[:one, :'(', :')', :two]` for an array of symbols.
@@ -182,6 +188,12 @@
       RUBY
     end
 
+    it 'does not register an offense for a %i array containing unescaped ( )' do
+      expect_no_offenses(<<~RUBY)
+        %i[one ( ) two]
+      RUBY
+    end
+
     it 'registers an offense for a %i array containing parentheses between parentheses' do
       expect_offense(<<~'RUBY')
         %i(one two \(\(\))