Add base64 to runtime dependency
#12094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR add `base64` to runtime dependency to suppress the following Ruby 3.3's warning: ```console $ ruby -v ruby 3.3.0dev (2023-08-03T00:11:08Z master 4b6c584023) [x86_64-darwin22] $ bundle exec rubocop base64 is not part of the default gems since Ruby 3.4.0. Add it to your Gemfile. ```
|
Thanks! |
krauselukas
added a commit
to openSUSE/open-build-service
that referenced
this pull request
Aug 14, 2023
base64 is part of the ruby stdlib https://stdgems.org/base64/. Rubocop adds it now as a gem dependency since it gets removed from the stdlib with ruby 3.4 rubocop/rubocop#12094. The introduced version of base64 matches the one of our currently used ruby version (3.1.4). We have to make sure that the version that now is included to our bundle does not mismatch in the future due to possible introduced updates.
krauselukas
added a commit
to openSUSE/open-build-service
that referenced
this pull request
Aug 14, 2023
base64 is part of the ruby stdlib https://stdgems.org/base64/. Rubocop adds it now as a gem dependency since it gets removed from the stdlib with ruby 3.4 rubocop/rubocop#12094. The introduced version of base64 matches the one of our currently used ruby version (3.1.4). We have to make sure that the version that now is included to our bundle does not mismatch in the future due to possible introduced updates.
krauselukas
added a commit
to openSUSE/open-build-service
that referenced
this pull request
Aug 14, 2023
base64 is part of the ruby stdlib https://stdgems.org/base64/. Rubocop adds it now as a gem dependency since it gets removed from the stdlib with ruby 3.4 rubocop/rubocop#12094. The introduced version of base64 matches the one of our currently used ruby version (3.1.4). We have to make sure that the version that now is included to our bundle does not mismatch in the future due to possible introduced updates.
krauselukas
added a commit
to openSUSE/open-build-service
that referenced
this pull request
Aug 14, 2023
base64 is part of the ruby stdlib https://stdgems.org/base64/. Rubocop adds it now as a gem dependency since it gets removed from the stdlib with ruby 3.4 rubocop/rubocop#12094. The introduced version of base64 matches the one of our currently used ruby version (3.1.4). We have to make sure that the version that now is included to our bundle does not mismatch in the future due to possible introduced updates.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add
base64to runtime dependency to suppress the following Ruby 3.3's warning:Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.