[rb] Add base64 gem as a runtime dependency
#13454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
add-base64-dep
branch
from
7f6749c
to
3f6eb54
Compare
|
Excellent. Can you add the version and re-run bundler for the lockfile? Thanks. |
Ruby 3.3 shows a warning if requiring base64 without specifying it in the gemspec Ruby 3.4 will throw a warning. See https://github.com/ruby/ruby/blob/master/doc/NEWS/NEWS-3.3.0.md#stdlib-updates Closes SeleniumHQ#13447
Earlopain
force-pushed
the
add-base64-dep
branch
from
3f6eb54
to
1a26ce3
Compare
|
Yeah, sure. Done |
|
@Earlopain Thanks for your help! |
Earlopain
added a commit
to Earlopain/selenium
that referenced
this pull request
Jun 5, 2024
This is getting the same treatment as the `base64` gem, starting with Ruby 3.4. Also see SeleniumHQ#13454 Closes SeleniumHQ#14081
8 tasks
titusfortner
pushed a commit
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #13447
Ruby 3.3 shows a warning if requiring base64 without specifying it in the gemspec
Ruby 3.4 will throw a warning.
See https://github.com/ruby/ruby/blob/master/doc/NEWS/NEWS-3.3.0.md#stdlib-updates
There is no version constraint on base64. This follows what other projects have done:
drb,mutex_mandbase64that are bundled gem candidates for Ruby 3.4 rails/rails#48907AddNevermind this one, I misrememberedbase64to runtime dependency rubocop/rubocop#12094There may be some issue with this in combination with older bundler versions. But since this gem requires Ruby >= 3.0 I don't think this is a concern.
Types of changes
Checklist