Merge pull request #11928 from koic/fix_incorrect_autocorrect_for_lin…

…t_ambiguous_block_association

Fix an incorrect autocorrect for `Lint/AmbiguousBlockAssociation`

changelog/fix_incorrect_autocorrect_for_lint_ambiguous_block_association.md

@@ -0,0 +1 @@
+* [#11928](https://github.com/rubocop/rubocop/pull/11928): Fix an incorrect autocorrect for `Lint/AmbiguousBlockAssociation`. ([@koic][])

lib/rubocop/cop/lint/ambiguous_block_association.rb

@@ -97,7 +97,8 @@ def message(send_node)
         def wrap_in_parentheses(corrector, node)
           range = node.loc.selector.end.join(node.first_argument.source_range.begin)
 
-          corrector.replace(range, '(')
+          corrector.remove(range)
+          corrector.insert_before(range, '(')
           corrector.insert_after(node.last_argument, ')')
         end
       end

spec/rubocop/cli/autocorrect_spec.rb

@@ -341,6 +341,28 @@ def batch
     RUBY
   end
 
+  it 'corrects `EnforcedStyle: require_parentheses` of `Style/MethodCallWithArgsParentheses` with ' \
+     '`Lint/AmbiguousBlockAssociation`' do
+    create_file('.rubocop.yml', <<~YAML)
+      Style/MethodCallWithArgsParentheses:
+        EnforcedStyle: require_parentheses
+    YAML
+    create_file('example.rb', <<~RUBY)
+      expect { foo }.not_to change { bar }
+    RUBY
+    expect(
+      cli.run(
+        [
+          '--autocorrect',
+          '--only', 'Style/MethodCallWithArgsParentheses,Lint/AmbiguousBlockAssociation'
+        ]
+      )
+    ).to eq(0)
+    expect(File.read('example.rb')).to eq(<<~RUBY)
+      expect { foo }.not_to(change { bar })
+    RUBY
+  end
+
   it 'corrects `EnforcedStyle: require_parentheses` of `Style/MethodCallWithArgsParentheses` with ' \
      '`Lint/AmbiguousOperator`' do
     create_file('.rubocop.yml', <<~YAML)