Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Parser 3.2.2.3 for Ruby 3.3.0dev as a runtime #11942

Merged
merged 1 commit into from Jun 9, 2023

Conversation

koic
Copy link
Member

@koic koic commented Jun 8, 2023

Follow up whitequark/parser#929 (comment)

For Ruby 3.3.0dev, this PR makes RuboCop require Parser 3.2.2.3 as a runtime dependency.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Follow up whitequark/parser#929 (comment)

For Ruby 3.3.0dev, this PR makes RuboCop require Parser 3.2.2.3 as a runtime dependency.
@koic koic merged commit 689d473 into rubocop:master Jun 9, 2023
28 checks passed
@koic koic deleted the require_parser_3_2_2_3_for_ruby_3_3 branch June 9, 2023 16:00
@tk0miya tk0miya mentioned this pull request Jun 14, 2023
tk0miya added a commit to tk0miya/rbs that referenced this pull request Jun 14, 2023
Since Ruby 3.3, racc has been promoted as bundled gems (see ruby#7877).
Therefore, this updates the rubocop and racc to make Ruby 3.3 CI
succeeded.

refs: rubocop/rubocop#11942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant