Fix broken CI #1353
Merged
Fix broken CI #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringio-3.0.7 was released at 2023/6/2 to support Ruby 3.3. https://github.com/ruby/stringio/blob/master/NEWS.md#307---2023-06-02 This upgrade it from 3.0.6 to 3.0.7 to resolve errors for master-nightly-* tests.
|
Oops. The new racc and rubocop package were released last week. So it's better to upgrade rubocop instead of pinning racc. |
Since Ruby 3.3, racc has been promoted as bundled gems (see ruby#7877). Therefore, this updates the rubocop and racc to make Ruby 3.3 CI succeeded. refs: rubocop/rubocop#11942
|
👍 |
|
Exactly. Racc will be installed as a dependency via Parser gem if RuboCop 1.52.1+ is used. |
soutaro
pushed a commit
that referenced
this pull request
Jul 18, 2023
Fix broken CI # Conflicts: # Gemfile.lock
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI has been broken because of changes in Ruby 3.3.
This fixes them and gets green again.
dep: Update stringio to 3.0.7 to support Ruby 3.3
stringio-3.0.7 was released at 2023/6/2 to support Ruby 3.3.
https://github.com/ruby/stringio/blob/master/NEWS.md#307---2023-06-02
This upgrade it from 3.0.6 to 3.0.7 to resolve errors for
master-nightly-* tests.
Workaround for Parser 3.2.2.2 or lower with Ruby 3.3.0devFollow up Try to promote racc as bundled gems ruby#7877.Ruby 3.3.0dev is set to promote Racc to a bundled gem. Therefore,this PR provides a workaround for Parser 3.2.2.2 or lower with Ruby
3.3.0dev to prevents the Ruby 3.3.0dev CI matrix error from rubocop.
refs: Workaround for Parser 3.2.2.2 or lower with Ruby 3.3.0dev rubocop/rubocop#11941
dep: Update rubocop to 1.52.1 to support Ruby 3.3
Since Ruby 3.3, racc has been promoted as bundled gems (see ruby#7877).
Therefore, this updates the rubocop and racc to make Ruby 3.3 CI
succeeded.
refs: Require Parser 3.2.2.3 for Ruby 3.3.0dev as a runtime rubocop/rubocop#11942