Update AssertOperator and RefuteOperator to allow :[] #264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
AssertOperator
andRefuteOperator
cops to allow:[]
The rubocop style guide prefers
assert
andrefute
for testing booleans. If I have an array of booleans, then I want to be able to use this style:This PR is suggested by an actual test in the Nokogiri suite which collects boolean values from Nokogiri::Reader as it passes through the document, and then checks the values after completing the parsing pass. That test could be rewritten, but I don't personally think it would be made more readable by that rewrite.
Also see #260 (comment) which raised the question of whether
:[]
was intentionally a violation.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.