Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AssertOperator and RefuteOperator to allow :[] #264

Conversation

flavorjones
Copy link
Contributor

@flavorjones flavorjones commented Sep 26, 2023

Update the AssertOperator and RefuteOperator cops to allow :[]

The rubocop style guide prefers assert and refute for testing booleans. If I have an array of booleans, then I want to be able to use this style:

  def test_my_array
    assert(array_of_bools[0])
    refute(array_of_bools[1])
  end

This PR is suggested by an actual test in the Nokogiri suite which collects boolean values from Nokogiri::Reader as it passes through the document, and then checks the values after completing the parsing pass. That test could be rewritten, but I don't personally think it would be made more readable by that rewrite.

Also see #260 (comment) which raised the question of whether :[] was intentionally a violation.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic
Copy link
Member

koic commented Sep 27, 2023

This seems like a reasonable change. Thank you!

koic added a commit that referenced this pull request Sep 27, 2023
@flavorjones flavorjones deleted the flavorjones-avoid-bracket-operator-in-assert-operator branch September 27, 2023 12:12
koic added a commit to koic/rubocop-minitest that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants