Bump the rubocop group with 2 updates #4999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps the rubocop group with 2 updates: [rubocop-capybara](https://github.com/rubocop/rubocop-capybara) and [rubocop-minitest](https://github.com/rubocop/rubocop-minitest). Updates `rubocop-capybara` from 2.18.0 to 2.19.0 - [Release notes](https://github.com/rubocop/rubocop-capybara/releases) - [Changelog](https://github.com/rubocop/rubocop-capybara/blob/main/CHANGELOG.md) - [Commits](rubocop/rubocop-capybara@v2.18.0...v2.19.0) Updates `rubocop-minitest` from 0.31.1 to 0.32.1 - [Release notes](https://github.com/rubocop/rubocop-minitest/releases) - [Changelog](https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-minitest@v0.31.1...v0.32.1) --- updated-dependencies: - dependency-name: rubocop-capybara dependency-type: direct:development update-type: version-update:semver-minor dependency-group: rubocop - dependency-name: rubocop-minitest dependency-type: direct:development update-type: version-update:semver-minor dependency-group: rubocop ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
jorg-vr
approved these changes
Sep 26, 2023
bmesuere
reviewed
Sep 27, 2023
Comment on lines
+661
to
+663
| assert_operator resp, :[], 'last_solution_is_best' | ||
| assert_operator resp, :[], 'has_solution' | ||
| assert_operator resp, :[], 'has_correct_solution' |
There was a problem hiding this comment.
What is the explanation of the cop responsible for this change? The original code is more readable to me.
There was a problem hiding this comment.
I agree. I also looked it up, but they only refer to this section of the styleguide https://minitest.rubystyle.guide/#assert-operator which isn't a lot more explicit about why
Some people on stackoverflow do suggest better assert failure messages when using assert operator
Anyway, this change will already be reverted in the next rubocop update rubocop/rubocop-minitest#264
So we might just close this pr and wait for the next one
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the rubocop group with 2 updates: rubocop-capybara and rubocop-minitest.
Updates
rubocop-capybarafrom 2.18.0 to 2.19.0Release notes
Sourced from rubocop-capybara's releases.
Changelog
Sourced from rubocop-capybara's changelog.
Commits
749c1c3Merge pull request #70 from rubocop/bump-version426fcb8Bump version v2.19.08696fddMerge pull request #66 from rubocop/fix/50292c1b8Fix an incorrect autocorrect forCapybara/CurrentPathExpectationd020309Merge pull request #69 from rubocop/fix-project-spec7bef12aMerge pull request #61 from rubocop/feature/5843d0eacAdd newCapybara/ClickLinkOrButtonStylecop02e0187Merge pull request #63 from rubocop/new_cop_have_selector56d339dImprove for project_spec54069a0Add newCapybara/RSpec/HaveSelectorcopUpdates
rubocop-minitestfrom 0.31.1 to 0.32.1Release notes
Sourced from rubocop-minitest's releases.
Changelog
Sourced from rubocop-minitest's changelog.
Commits
039ba38Cut 0.32.11f90acfUpdate Changelog4794578Merge pull request #262 from koic/fix_an_error_for_assert_operator9aad91a[Fix #261] Fix an error forMinitest/AssertOperator4c0d555Switch back docs version to master801bc2bCut 0.32.0f22bd90Update Changelog71f70d7Merge pull request #260 from koic/add_new_minitest_assert_operator_and_refute...95e0cde[Fix #255] Add newMinitest/AssertOperatorandMinitest/RefuteOperatorcops6832890Fix duplicate contributor names when generating changelogDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions