Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Sequence instead of List for nameservers, as List is invariant #961

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Use Sequence instead of List for nameservers, as List is invariant #961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions dns/resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import threading
import time
import warnings
from typing import Any, Dict, Iterator, List, Optional, Tuple, Union
from typing import Any, Dict, Iterator, List, Optional, Sequence, Tuple, Union
from urllib.parse import urlparse

import dns._ddr
Expand Down Expand Up @@ -920,7 +920,7 @@ class BaseResolver:
retry_servfail: bool
rotate: bool
ndots: Optional[int]
_nameservers: List[Union[str, dns.nameserver.Nameserver]]
_nameservers: Sequence[Union[str, dns.nameserver.Nameserver]]

def __init__(
self, filename: str = "/etc/resolv.conf", configure: bool = True
Expand Down Expand Up @@ -1176,7 +1176,7 @@ def set_flags(self, flags: int) -> None:
@classmethod
def _enrich_nameservers(
cls,
nameservers: List[Union[str, dns.nameserver.Nameserver]],
nameservers: Sequence[Union[str, dns.nameserver.Nameserver]],
nameserver_ports: Dict[str, int],
default_port: int,
) -> List[dns.nameserver.Nameserver]:
Expand Down Expand Up @@ -1214,12 +1214,12 @@ def _enrich_nameservers(
@property
def nameservers(
self,
) -> List[Union[str, dns.nameserver.Nameserver]]:
) -> Sequence[Union[str, dns.nameserver.Nameserver]]:
return self._nameservers

@nameservers.setter
def nameservers(
self, nameservers: List[Union[str, dns.nameserver.Nameserver]]
self, nameservers: Sequence[Union[str, dns.nameserver.Nameserver]]
) -> None:
"""
*nameservers*, a ``list`` of nameservers, where a nameserver is either
Expand Down