Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Sequence instead of List for nameservers, as List is invariant #961

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Use Sequence instead of List for nameservers, as List is invariant #961

merged 1 commit into from
Jul 19, 2023

Commits on Jul 18, 2023

  1. Use Sequence instead of List for nameservers, as List is invariant 

    without this, resolver.nameservers = string.split() produces mypy error, see
https://mypy.readthedocs.io/en/stable/common_issues.html#invariance-vs-covariance
    @av223119
    av223119 committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    53ab680 View commit details
    Browse the repository at this point in the history