-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash field expiration commands #3218
Open
gerzse
wants to merge
11
commits into
redis:master
Choose a base branch
from
gerzse:hash-fields-expiration
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9e5a797
Hash field expiration commands
93f6ddb
Merge remote-tracking branch 'origin/master' into hash-fields-expiration
4ce03fb
Remove doctests and switch to Google style docstrings
b4cd85a
Fix linter errors
8316fd3
Sphinx config
92a02fe
Merge remote-tracking branch 'origin/master' into hash-fields-expiration
6f07645
Add FIELDS keyword to commands
82c6582
Cover HGETF and HSETF
74b8fe8
Merge remote-tracking branch 'origin/master' into hash-fields-expiration
6a61ef1
Adapt to latest server side changes
3430e61
Merge remote-tracking branch 'origin/master' into hash-fields-expiration
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW on the topic of docstrings : as mentioned by this discussion in Stackoverflow we can use the Pyment tool to generate new reST documentation or convert existing one from other formats. This is probably going to help in the general direction of consistency.
IMHO it is a good idea to continue with the reST format you are using here chiefly because of two things - we can generate documentation using Sphinx and it is generally recommended by PEP 287
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After trying out some more things, I think that the Google style documentation would be better suited. The main reason is that it supports bullet lists in a straightforward way. With reST I could not get a bullet list properly formatted in the PyCharm documentation popup.
Also it seems to me that a great deal of the existing documentation is a flavor of the Google style. It would be the least effort to convert it to the proper Google format.
And, after enabling the
napoleon
preprocessor for Sphinx, this Google style documentation also gets converted well (after some additional fine tuning related to typing).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.