Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash field expiration commands #3218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented Apr 26, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Hash field expiration commands

@gerzse gerzse requested review from uglide and tishun April 29, 2024 06:59
@gerzse gerzse added the feature New feature label Apr 29, 2024
gt: bool = False,
lt: bool = False,
) -> ResponseT:
"""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW on the topic of docstrings : as mentioned by this discussion in Stackoverflow we can use the Pyment tool to generate new reST documentation or convert existing one from other formats. This is probably going to help in the general direction of consistency.

IMHO it is a good idea to continue with the reST format you are using here chiefly because of two things - we can generate documentation using Sphinx and it is generally recommended by PEP 287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants