Catch Exception and not BaseException in the Connection
#2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2104 +/- ##
==========================================
- Coverage 92.21% 92.20% -0.01%
==========================================
Files 111 111
Lines 28781 28853 +72
==========================================
+ Hits 26539 26605 +66
- Misses 2242 2248 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
WisdomPill
reviewed
Apr 23, 2022
|
@kristjanvalur Why did you catch Exception rather that BaseException? Was there an inheritance issue you saw? |
|
I can add tests. As I explained in the defect, |
|
In fact, I don't see why there is a |
|
(There isn't an equivalent non-async test that can be easily done, without writing a thread-based timeout class.) |
|
Hm, now it is mysteriously failing. it asserts on the "assert pubsub.connection.is_connected" |
kristjanvalur
force-pushed
the
pr-exception
branch
6 times, most recently
from
83d7825
to
8a9cc1f
Compare
|
Well, it seems I cracked the unittest problem I was having. Turned out that only in Python 3.8 did asyncio.CancelledError get promoted to BaseException. |
|
any responses? @WisdomPill ? |
|
I'll clean up the commit history a bit... |
kristjanvalur
force-pushed
the
pr-exception
branch
from
f7a7498
to
c4f9e9f
Compare
|
yet another fluke test failure. |
kristjanvalur
force-pushed
the
pr-exception
branch
4 times, most recently
from
a051aca
to
4af0924
Compare
kristjanvalur
force-pushed
the
pr-exception
branch
4 times, most recently
from
4c65513
to
918d104
Compare
6 tasks
kristjanvalur
force-pushed
the
pr-exception
branch
from
e482225
to
c633ab9
Compare
|
I bumped into this too – trying to e.g. ctrl+c out of py.test requires a couple of tries because |
kristjanvalur
force-pushed
the
pr-exception
branch
from
c633ab9
to
75fc8f6
Compare
kristjanvalur
force-pushed
the
pr-exception
branch
from
75fc8f6
to
26058fa
Compare
dvora-h
added
bug
dvora-h
approved these changes
Sep 29, 2022
|
woo-hoo! |
|
Thanks for this! And sorry this (and your other PR's) waited so long... |
kosuke-zhang
pushed a commit
to uup-saas/redis-py
that referenced
this pull request
Dec 4, 2022
…2104) * Add failing unittests for passing BaseException through * Resolve failing unittest * Remove redundant checks for asyncio.CancelledError
6 tasks
tobymao
added a commit
to tobymao/saq
that referenced
this pull request
Dec 14, 2022
6 tasks
This was referenced Apr 5, 2023
6 tasks
Petitoto
pushed a commit
to aeecleclair/Hyperion
that referenced
this pull request
Aug 19, 2023
Bumps [redis](https://github.com/redis/redis-py) from 4.6.0 to 5.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/redis/redis-py/releases">redis's releases</a>.</em></p> <blockquote> <h2>5.0.0</h2> <h2>What's new?</h2> <h3>Triggers and Functions support</h3> <p>Triggers and Functions allow you to execute server-side functions triggered when key values are modified or created in Redis, a stream entry arrival, or explicitly calling them. Simply put, you can replace Lua scripts with easy-to-develop JavaScript or TypeScript code. Move your business logic closer to the data to ensure a lower latency, and forget about updating dependent key values manually in your code. <a href="https://redis.io/docs/interact/programmability/triggers-and-functions/quick_start/">Try it for yourself with Quick start</a></p> <h3>Full Redis 7.2 and <a href="https://github.com/redis/redis-specifications/blob/master/protocol/RESP3.md">RESP3 support</a></h3> <h3>Python 3.7 End-of-Life</h3> <p><a href="https://devguide.python.org/versions/">Python 3.7 has reached its end-of-life (EOL) as of June 2023</a>. This means that starting from this date, Python 3.7 will no longer receive any updates, including security patches, bug fixes, or improvements. If you continue to use Python 3.7 post-EOL, you may expose your projects and systems to potential security vulnerabilities. We ended its support in this version and strongly recommend migrating to Python 3.10.</p> <h2>🐛 Bug Fixes</h2> <ul> <li>Fix timeout retrying on pipeline execution (<a href="https://redirect.github.com/redis/redis-py/issues/2812">#2812</a>)</li> <li>Fix socket garbage collection (<a href="https://redirect.github.com/redis/redis-py/issues/2859">#2859</a>)</li> </ul> <h2>🧰 Maintenance</h2> <ul> <li>Updating client license to clear, MIT (<a href="https://redirect.github.com/redis/redis-py/issues/2884">#2884</a>)</li> <li>Add py.typed in accordance with PEP-561 (<a href="https://redirect.github.com/redis/redis-py/issues/2738">#2738</a>)</li> <li>Dependabot label change (<a href="https://redirect.github.com/redis/redis-py/issues/2880">#2880</a>)</li> <li>Fix type hints in SearchCommands (<a href="https://redirect.github.com/redis/redis-py/issues/2817">#2817</a>)</li> <li>Add sync modules (except search) tests to cluster CI (<a href="https://redirect.github.com/redis/redis-py/issues/2850">#2850</a>)</li> <li>Fix a duplicate word in <code>CONTRIBUTING.md</code> (<a href="https://redirect.github.com/redis/redis-py/issues/2848">#2848</a>)</li> <li>Fixing doc builds (<a href="https://redirect.github.com/redis/redis-py/issues/2869">#2869</a>)</li> <li>Change cluster docker to edge and enable debug command (<a href="https://redirect.github.com/redis/redis-py/issues/2853">#2853</a>)</li> </ul> <h2>Contributors</h2> <p>We'd like to thank all the contributors who worked on this release!</p> <p><a href="https://github.com/JoanFM"><code>@JoanFM</code></a>, <a href="https://github.com/Ovsyanka83"><code>@Ovsyanka83</code></a>, <a href="https://github.com/chayim"><code>@chayim</code></a>, <a href="https://github.com/dependabot"><code>@dependabot</code></a>, <a href="https://github.com/dependabot"><code>@dependabot</code></a>[bot], <a href="https://github.com/dvora-h"><code>@dvora-h</code></a>, <a href="https://github.com/kristjanvalur"><code>@kristjanvalur</code></a>, <a href="https://github.com/kurtmckee"><code>@kurtmckee</code></a>, <a href="https://github.com/pall-j"><code>@pall-j</code></a> and <a href="https://github.com/shacharPash"><code>@shacharPash</code></a></p> <h2>5.0.0rc2</h2> <h2>Changes</h2> <h2>🧰 Maintenance</h2> <ul> <li>RESP3 response-callbacks cleanup (<a href="https://redirect.github.com/redis/redis-py/issues/2841">#2841</a>)</li> <li>Merge master to 5.0 (<a href="https://redirect.github.com/redis/redis-py/issues/2827">#2827</a>)</li> </ul> <h2>5.0.0rc1</h2> <h2>Changes</h2> <h2>🔥 Breaking Changes</h2> <ul> <li>Change <code>SISMEMBER</code> return type to int by (<a href="https://redirect.github.com/redis/redis-py/issues/2813">#2813</a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/redis/redis-py/blob/master/CHANGES">redis's changelog</a>.</em></p> <blockquote> <pre><code>* Fix [#2831](redis/redis-py#2831), add auto_close_connection_pool=True arg to asyncio.Redis.from_url() * Fix incorrect redis.asyncio.Cluster type hint for `retry_on_error` * Fix dead weakref in sentinel connection causing ReferenceError ([#2767](redis/redis-py#2767)) * Fix [#2768](redis/redis-py#2768), Fix KeyError: 'first-entry' in parse_xinfo_stream. * Fix [#2749](redis/redis-py#2749), remove unnecessary __del__ logic to close connections. * Fix [#2754](redis/redis-py#2754), adding a missing argument to SentinelManagedConnection * Fix `xadd` command to accept non-negative `maxlen` including 0 * Revert [#2104](redis/redis-py#2104), [#2673](redis/redis-py#2673), add `disconnect_on_error` option to `read_response()` (issues [#2506](redis/redis-py#2506), [#2624](redis/redis-py#2624)) * Add `address_remap` parameter to `RedisCluster` * Fix incorrect usage of once flag in async Sentinel * asyncio: Fix memory leak caused by hiredis ([#2693](redis/redis-py#2693)) * Allow data to drain from async PythonParser when reading during a disconnect() * Use asyncio.timeout() instead of async_timeout.timeout() for python >= 3.11 ([#2602](redis/redis-py#2602)) * Add a Dependabot configuration to auto-update GitHub action versions. * Add test and fix async HiredisParser when reading during a disconnect() ([#2349](redis/redis-py#2349)) * Use hiredis-py pack_command if available. * Support `.unlink()` in ClusterPipeline * Simplify synchronous SocketBuffer state management * Fix string cleanse in Redis Graph * Make PythonParser resumable in case of error ([#2510](redis/redis-py#2510)) * Add `timeout=None` in `SentinelConnectionManager.read_response` * Documentation fix: password protected socket connection ([#2374](redis/redis-py#2374)) * Allow `timeout=None` in `PubSub.get_message()` to wait forever * add `nowait` flag to `asyncio.Connection.disconnect()` * Update README.md links * Fix timezone handling for datetime to unixtime conversions * Fix start_id type for XAUTOCLAIM * Remove verbose logging from cluster.py * Add retry mechanism to async version of Connection * Compare commands case-insensitively in the asyncio command parser * Allow negative `retries` for `Retry` class to retry forever * Add `items` parameter to `hset` signature * Create codeql-analysis.yml ([#1988](redis/redis-py#1988)). Thanks @chayim * Add limited support for Lua scripting with RedisCluster * Implement `.lock()` method on RedisCluster * Fix cursor returned by SCAN for RedisCluster & change default target to PRIMARIES * Fix scan_iter for RedisCluster * Remove verbose logging when initializing ClusterPubSub, ClusterPipeline or RedisCluster * Fix broken connection writer lock-up for asyncio ([#2065](redis/redis-py#2065)) * Fix auth bug when provided with no username ([#2086](redis/redis-py#2086)) * Fix missing ClusterPipeline._lock ([#2189](redis/redis-py#2189)) * Added dynaminc_startup_nodes configuration to RedisCluster * Fix reusing the old nodes' connections when cluster topology refresh is being done * Fix RedisCluster to immediately raise AuthenticationError without a retry * ClusterPipeline Doesn't Handle ConnectionError for Dead Hosts ([#2225](redis/redis-py#2225)) * Remove compatibility code for old versions of Hiredis, drop Packaging dependency * The `deprecated` library is no longer a dependency * Failover handling improvements for RedisCluster and Async RedisCluster ([#2377](redis/redis-py#2377)) * Fixed "cannot pickle '_thread.lock' object" bug ([#2354](redis/redis-py#2354), [#2297](redis/redis-py#2297)) * Added CredentialsProvider class to support password rotation </code></pre> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/redis/redis-py/commit/28cc65c18cc4fb37ef14497c963eb181dba8d25d"><code>28cc65c</code></a> Updating all client licenses to clearly be MIT (<a href="https://redirect.github.com/redis/redis-py/issues/2884">#2884</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/2f679261b7ef0e7372868cacd8ba8721406eb495"><code>2f67926</code></a> Version 5.0.0 (<a href="https://redirect.github.com/redis/redis-py/issues/2874">#2874</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/f121cf29e7d7fb5c85c5915ba5ce10a20826e8c0"><code>f121cf2</code></a> Add support for <code>CLIENT SETINFO</code> (<a href="https://redirect.github.com/redis/redis-py/issues/2857">#2857</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/d5c2d1d42ed9f653d450e6127cb6f673f43fb2d0"><code>d5c2d1d</code></a> Adding support for triggered functions (TFUNCTION) (<a href="https://redirect.github.com/redis/redis-py/issues/2861">#2861</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/b0abd555770bba42c57881b488b5fe5b188f088e"><code>b0abd55</code></a> RESP 3 feature documentation (<a href="https://redirect.github.com/redis/redis-py/issues/2872">#2872</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/a532f89adcd5b790e2811588a2d7c34a79b095d5"><code>a532f89</code></a> Add py.typed in accordance with PEP-561 (<a href="https://redirect.github.com/redis/redis-py/issues/2738">#2738</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/673617d2cbac265c6c8d43280d5e6898df4572b6"><code>673617d</code></a> Bump actions/upload-artifact from 2 to 3 (<a href="https://redirect.github.com/redis/redis-py/issues/2877">#2877</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/0ed807777cfab129904fd72fbada793f21ea0a9c"><code>0ed8077</code></a> Bump pypa/gh-action-pip-audit from 1.0.0 to 1.0.8 (<a href="https://redirect.github.com/redis/redis-py/issues/2879">#2879</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/38c7de617a482c9dd2d40699fbdd7ce44736cae9"><code>38c7de6</code></a> Dependabot label change (<a href="https://redirect.github.com/redis/redis-py/issues/2880">#2880</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/8370c4ac20835002fd1044e1742986072f19289c"><code>8370c4a</code></a> Add a Dependabot config to auto-update GitHub action versions (<a href="https://redirect.github.com/redis/redis-py/issues/2847">#2847</a>)</li> <li>Additional commits viewable in <a href="https://github.com/redis/redis-py/compare/v4.6.0...v5.0.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
oleobal
pushed a commit
to Substra/substra-backend
that referenced
this pull request
Sep 11, 2023
Bumps [redis](https://github.com/redis/redis-py) from 4.5.4 to 5.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/redis/redis-py/releases">redis's releases</a>.</em></p> <blockquote> <h2>5.0.0</h2> <h2>What's new?</h2> <h3>Triggers and Functions support</h3> <p>Triggers and Functions allow you to execute server-side functions triggered when key values are modified or created in Redis, a stream entry arrival, or explicitly calling them. Simply put, you can replace Lua scripts with easy-to-develop JavaScript or TypeScript code. Move your business logic closer to the data to ensure a lower latency, and forget about updating dependent key values manually in your code. <a href="https://redis.io/docs/interact/programmability/triggers-and-functions/quick_start/">Try it for yourself with Quick start</a></p> <h3>Full <a href="https://redis.com/blog/introducing-redis-7-2/">Redis 7.2</a> and <a href="https://github.com/redis/redis-specifications/blob/master/protocol/RESP3.md">RESP3 support</a></h3> <h3>Python 3.7 End-of-Life</h3> <p><a href="https://devguide.python.org/versions/">Python 3.7 has reached its end-of-life (EOL) as of June 2023</a>. This means that starting from this date, Python 3.7 will no longer receive any updates, including security patches, bug fixes, or improvements. If you continue to use Python 3.7 post-EOL, you may expose your projects and systems to potential security vulnerabilities. We ended its support in this version and strongly recommend migrating to Python 3.10.</p> <h2>🐛 Bug Fixes</h2> <ul> <li>Fix timeout retrying on pipeline execution (<a href="https://redirect.github.com/redis/redis-py/issues/2812">#2812</a>)</li> <li>Fix socket garbage collection (<a href="https://redirect.github.com/redis/redis-py/issues/2859">#2859</a>)</li> </ul> <h2>🧰 Maintenance</h2> <ul> <li>Updating client license to clear, MIT (<a href="https://redirect.github.com/redis/redis-py/issues/2884">#2884</a>)</li> <li>Add py.typed in accordance with PEP-561 (<a href="https://redirect.github.com/redis/redis-py/issues/2738">#2738</a>)</li> <li>Dependabot label change (<a href="https://redirect.github.com/redis/redis-py/issues/2880">#2880</a>)</li> <li>Fix type hints in SearchCommands (<a href="https://redirect.github.com/redis/redis-py/issues/2817">#2817</a>)</li> <li>Add sync modules (except search) tests to cluster CI (<a href="https://redirect.github.com/redis/redis-py/issues/2850">#2850</a>)</li> <li>Fix a duplicate word in <code>CONTRIBUTING.md</code> (<a href="https://redirect.github.com/redis/redis-py/issues/2848">#2848</a>)</li> <li>Fixing doc builds (<a href="https://redirect.github.com/redis/redis-py/issues/2869">#2869</a>)</li> <li>Change cluster docker to edge and enable debug command (<a href="https://redirect.github.com/redis/redis-py/issues/2853">#2853</a>)</li> </ul> <h2>Contributors</h2> <p>We'd like to thank all the contributors who worked on this release!</p> <p><a href="https://github.com/JoanFM"><code>@JoanFM</code></a>, <a href="https://github.com/Ovsyanka83"><code>@Ovsyanka83</code></a>, <a href="https://github.com/chayim"><code>@chayim</code></a>, <a href="https://github.com/dependabot"><code>@dependabot</code></a>, <a href="https://github.com/dependabot"><code>@dependabot</code></a>[bot], <a href="https://github.com/dvora-h"><code>@dvora-h</code></a>, <a href="https://github.com/kristjanvalur"><code>@kristjanvalur</code></a>, <a href="https://github.com/kurtmckee"><code>@kurtmckee</code></a>, <a href="https://github.com/pall-j"><code>@pall-j</code></a> and <a href="https://github.com/shacharPash"><code>@shacharPash</code></a></p> <h2>5.0.0rc2</h2> <h2>Changes</h2> <h2>🧰 Maintenance</h2> <ul> <li>RESP3 response-callbacks cleanup (<a href="https://redirect.github.com/redis/redis-py/issues/2841">#2841</a>)</li> <li>Merge master to 5.0 (<a href="https://redirect.github.com/redis/redis-py/issues/2827">#2827</a>)</li> </ul> <h2>5.0.0rc1</h2> <h2>Changes</h2> <h2>🔥 Breaking Changes</h2> <ul> <li>Change <code>SISMEMBER</code> return type to int by (<a href="https://redirect.github.com/redis/redis-py/issues/2813">#2813</a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/redis/redis-py/blob/master/CHANGES">redis's changelog</a>.</em></p> <blockquote> <pre><code>* Fix [#2831](redis/redis-py#2831), add auto_close_connection_pool=True arg to asyncio.Redis.from_url() * Fix incorrect redis.asyncio.Cluster type hint for `retry_on_error` * Fix dead weakref in sentinel connection causing ReferenceError ([#2767](redis/redis-py#2767)) * Fix [#2768](redis/redis-py#2768), Fix KeyError: 'first-entry' in parse_xinfo_stream. * Fix [#2749](redis/redis-py#2749), remove unnecessary __del__ logic to close connections. * Fix [#2754](redis/redis-py#2754), adding a missing argument to SentinelManagedConnection * Fix `xadd` command to accept non-negative `maxlen` including 0 * Revert [#2104](redis/redis-py#2104), [#2673](redis/redis-py#2673), add `disconnect_on_error` option to `read_response()` (issues [#2506](redis/redis-py#2506), [#2624](redis/redis-py#2624)) * Add `address_remap` parameter to `RedisCluster` * Fix incorrect usage of once flag in async Sentinel * asyncio: Fix memory leak caused by hiredis ([#2693](redis/redis-py#2693)) * Allow data to drain from async PythonParser when reading during a disconnect() * Use asyncio.timeout() instead of async_timeout.timeout() for python >= 3.11 ([#2602](redis/redis-py#2602)) * Add a Dependabot configuration to auto-update GitHub action versions. * Add test and fix async HiredisParser when reading during a disconnect() ([#2349](redis/redis-py#2349)) * Use hiredis-py pack_command if available. * Support `.unlink()` in ClusterPipeline * Simplify synchronous SocketBuffer state management * Fix string cleanse in Redis Graph * Make PythonParser resumable in case of error ([#2510](redis/redis-py#2510)) * Add `timeout=None` in `SentinelConnectionManager.read_response` * Documentation fix: password protected socket connection ([#2374](redis/redis-py#2374)) * Allow `timeout=None` in `PubSub.get_message()` to wait forever * add `nowait` flag to `asyncio.Connection.disconnect()` * Update README.md links * Fix timezone handling for datetime to unixtime conversions * Fix start_id type for XAUTOCLAIM * Remove verbose logging from cluster.py * Add retry mechanism to async version of Connection * Compare commands case-insensitively in the asyncio command parser * Allow negative `retries` for `Retry` class to retry forever * Add `items` parameter to `hset` signature * Create codeql-analysis.yml ([#1988](redis/redis-py#1988)). Thanks @chayim * Add limited support for Lua scripting with RedisCluster * Implement `.lock()` method on RedisCluster * Fix cursor returned by SCAN for RedisCluster & change default target to PRIMARIES * Fix scan_iter for RedisCluster * Remove verbose logging when initializing ClusterPubSub, ClusterPipeline or RedisCluster * Fix broken connection writer lock-up for asyncio ([#2065](redis/redis-py#2065)) * Fix auth bug when provided with no username ([#2086](redis/redis-py#2086)) * Fix missing ClusterPipeline._lock ([#2189](redis/redis-py#2189)) * Added dynaminc_startup_nodes configuration to RedisCluster * Fix reusing the old nodes' connections when cluster topology refresh is being done * Fix RedisCluster to immediately raise AuthenticationError without a retry * ClusterPipeline Doesn't Handle ConnectionError for Dead Hosts ([#2225](redis/redis-py#2225)) * Remove compatibility code for old versions of Hiredis, drop Packaging dependency * The `deprecated` library is no longer a dependency * Failover handling improvements for RedisCluster and Async RedisCluster ([#2377](redis/redis-py#2377)) * Fixed "cannot pickle '_thread.lock' object" bug ([#2354](redis/redis-py#2354), [#2297](redis/redis-py#2297)) * Added CredentialsProvider class to support password rotation </code></pre> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/redis/redis-py/commit/28cc65c18cc4fb37ef14497c963eb181dba8d25d"><code>28cc65c</code></a> Updating all client licenses to clearly be MIT (<a href="https://redirect.github.com/redis/redis-py/issues/2884">#2884</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/2f679261b7ef0e7372868cacd8ba8721406eb495"><code>2f67926</code></a> Version 5.0.0 (<a href="https://redirect.github.com/redis/redis-py/issues/2874">#2874</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/f121cf29e7d7fb5c85c5915ba5ce10a20826e8c0"><code>f121cf2</code></a> Add support for <code>CLIENT SETINFO</code> (<a href="https://redirect.github.com/redis/redis-py/issues/2857">#2857</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/d5c2d1d42ed9f653d450e6127cb6f673f43fb2d0"><code>d5c2d1d</code></a> Adding support for triggered functions (TFUNCTION) (<a href="https://redirect.github.com/redis/redis-py/issues/2861">#2861</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/b0abd555770bba42c57881b488b5fe5b188f088e"><code>b0abd55</code></a> RESP 3 feature documentation (<a href="https://redirect.github.com/redis/redis-py/issues/2872">#2872</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/a532f89adcd5b790e2811588a2d7c34a79b095d5"><code>a532f89</code></a> Add py.typed in accordance with PEP-561 (<a href="https://redirect.github.com/redis/redis-py/issues/2738">#2738</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/673617d2cbac265c6c8d43280d5e6898df4572b6"><code>673617d</code></a> Bump actions/upload-artifact from 2 to 3 (<a href="https://redirect.github.com/redis/redis-py/issues/2877">#2877</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/0ed807777cfab129904fd72fbada793f21ea0a9c"><code>0ed8077</code></a> Bump pypa/gh-action-pip-audit from 1.0.0 to 1.0.8 (<a href="https://redirect.github.com/redis/redis-py/issues/2879">#2879</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/38c7de617a482c9dd2d40699fbdd7ce44736cae9"><code>38c7de6</code></a> Dependabot label change (<a href="https://redirect.github.com/redis/redis-py/issues/2880">#2880</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/8370c4ac20835002fd1044e1742986072f19289c"><code>8370c4a</code></a> Add a Dependabot config to auto-update GitHub action versions (<a href="https://redirect.github.com/redis/redis-py/issues/2847">#2847</a>)</li> <li>Additional commits viewable in <a href="https://github.com/redis/redis-py/compare/v4.5.4...v5.0.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
oleobal
pushed a commit
to Substra/substra-backend
that referenced
this pull request
Sep 11, 2023
Bumps [redis](https://github.com/redis/redis-py) from 4.6.0 to 5.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/redis/redis-py/releases">redis's releases</a>.</em></p> <blockquote> <h2>5.0.0</h2> <h2>What's new?</h2> <h3>Triggers and Functions support</h3> <p>Triggers and Functions allow you to execute server-side functions triggered when key values are modified or created in Redis, a stream entry arrival, or explicitly calling them. Simply put, you can replace Lua scripts with easy-to-develop JavaScript or TypeScript code. Move your business logic closer to the data to ensure a lower latency, and forget about updating dependent key values manually in your code. <a href="https://redis.io/docs/interact/programmability/triggers-and-functions/quick_start/">Try it for yourself with Quick start</a></p> <h3>Full <a href="https://redis.com/blog/introducing-redis-7-2/">Redis 7.2</a> and <a href="https://github.com/redis/redis-specifications/blob/master/protocol/RESP3.md">RESP3 support</a></h3> <h3>Python 3.7 End-of-Life</h3> <p><a href="https://devguide.python.org/versions/">Python 3.7 has reached its end-of-life (EOL) as of June 2023</a>. This means that starting from this date, Python 3.7 will no longer receive any updates, including security patches, bug fixes, or improvements. If you continue to use Python 3.7 post-EOL, you may expose your projects and systems to potential security vulnerabilities. We ended its support in this version and strongly recommend migrating to Python 3.10.</p> <h2>🐛 Bug Fixes</h2> <ul> <li>Fix timeout retrying on pipeline execution (<a href="https://redirect.github.com/redis/redis-py/issues/2812">#2812</a>)</li> <li>Fix socket garbage collection (<a href="https://redirect.github.com/redis/redis-py/issues/2859">#2859</a>)</li> </ul> <h2>🧰 Maintenance</h2> <ul> <li>Updating client license to clear, MIT (<a href="https://redirect.github.com/redis/redis-py/issues/2884">#2884</a>)</li> <li>Add py.typed in accordance with PEP-561 (<a href="https://redirect.github.com/redis/redis-py/issues/2738">#2738</a>)</li> <li>Dependabot label change (<a href="https://redirect.github.com/redis/redis-py/issues/2880">#2880</a>)</li> <li>Fix type hints in SearchCommands (<a href="https://redirect.github.com/redis/redis-py/issues/2817">#2817</a>)</li> <li>Add sync modules (except search) tests to cluster CI (<a href="https://redirect.github.com/redis/redis-py/issues/2850">#2850</a>)</li> <li>Fix a duplicate word in <code>CONTRIBUTING.md</code> (<a href="https://redirect.github.com/redis/redis-py/issues/2848">#2848</a>)</li> <li>Fixing doc builds (<a href="https://redirect.github.com/redis/redis-py/issues/2869">#2869</a>)</li> <li>Change cluster docker to edge and enable debug command (<a href="https://redirect.github.com/redis/redis-py/issues/2853">#2853</a>)</li> </ul> <h2>Contributors</h2> <p>We'd like to thank all the contributors who worked on this release!</p> <p><a href="https://github.com/JoanFM"><code>@JoanFM</code></a>, <a href="https://github.com/Ovsyanka83"><code>@Ovsyanka83</code></a>, <a href="https://github.com/chayim"><code>@chayim</code></a>, <a href="https://github.com/dependabot"><code>@dependabot</code></a>, <a href="https://github.com/dependabot"><code>@dependabot</code></a>[bot], <a href="https://github.com/dvora-h"><code>@dvora-h</code></a>, <a href="https://github.com/kristjanvalur"><code>@kristjanvalur</code></a>, <a href="https://github.com/kurtmckee"><code>@kurtmckee</code></a>, <a href="https://github.com/pall-j"><code>@pall-j</code></a> and <a href="https://github.com/shacharPash"><code>@shacharPash</code></a></p> <h2>5.0.0rc2</h2> <h2>Changes</h2> <h2>🧰 Maintenance</h2> <ul> <li>RESP3 response-callbacks cleanup (<a href="https://redirect.github.com/redis/redis-py/issues/2841">#2841</a>)</li> <li>Merge master to 5.0 (<a href="https://redirect.github.com/redis/redis-py/issues/2827">#2827</a>)</li> </ul> <h2>5.0.0rc1</h2> <h2>Changes</h2> <h2>🔥 Breaking Changes</h2> <ul> <li>Change <code>SISMEMBER</code> return type to int by (<a href="https://redirect.github.com/redis/redis-py/issues/2813">#2813</a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/redis/redis-py/blob/master/CHANGES">redis's changelog</a>.</em></p> <blockquote> <pre><code>* Fix [#2831](redis/redis-py#2831), add auto_close_connection_pool=True arg to asyncio.Redis.from_url() * Fix incorrect redis.asyncio.Cluster type hint for `retry_on_error` * Fix dead weakref in sentinel connection causing ReferenceError ([#2767](redis/redis-py#2767)) * Fix [#2768](redis/redis-py#2768), Fix KeyError: 'first-entry' in parse_xinfo_stream. * Fix [#2749](redis/redis-py#2749), remove unnecessary __del__ logic to close connections. * Fix [#2754](redis/redis-py#2754), adding a missing argument to SentinelManagedConnection * Fix `xadd` command to accept non-negative `maxlen` including 0 * Revert [#2104](redis/redis-py#2104), [#2673](redis/redis-py#2673), add `disconnect_on_error` option to `read_response()` (issues [#2506](redis/redis-py#2506), [#2624](redis/redis-py#2624)) * Add `address_remap` parameter to `RedisCluster` * Fix incorrect usage of once flag in async Sentinel * asyncio: Fix memory leak caused by hiredis ([#2693](redis/redis-py#2693)) * Allow data to drain from async PythonParser when reading during a disconnect() * Use asyncio.timeout() instead of async_timeout.timeout() for python >= 3.11 ([#2602](redis/redis-py#2602)) * Add a Dependabot configuration to auto-update GitHub action versions. * Add test and fix async HiredisParser when reading during a disconnect() ([#2349](redis/redis-py#2349)) * Use hiredis-py pack_command if available. * Support `.unlink()` in ClusterPipeline * Simplify synchronous SocketBuffer state management * Fix string cleanse in Redis Graph * Make PythonParser resumable in case of error ([#2510](redis/redis-py#2510)) * Add `timeout=None` in `SentinelConnectionManager.read_response` * Documentation fix: password protected socket connection ([#2374](redis/redis-py#2374)) * Allow `timeout=None` in `PubSub.get_message()` to wait forever * add `nowait` flag to `asyncio.Connection.disconnect()` * Update README.md links * Fix timezone handling for datetime to unixtime conversions * Fix start_id type for XAUTOCLAIM * Remove verbose logging from cluster.py * Add retry mechanism to async version of Connection * Compare commands case-insensitively in the asyncio command parser * Allow negative `retries` for `Retry` class to retry forever * Add `items` parameter to `hset` signature * Create codeql-analysis.yml ([#1988](redis/redis-py#1988)). Thanks @chayim * Add limited support for Lua scripting with RedisCluster * Implement `.lock()` method on RedisCluster * Fix cursor returned by SCAN for RedisCluster & change default target to PRIMARIES * Fix scan_iter for RedisCluster * Remove verbose logging when initializing ClusterPubSub, ClusterPipeline or RedisCluster * Fix broken connection writer lock-up for asyncio ([#2065](redis/redis-py#2065)) * Fix auth bug when provided with no username ([#2086](redis/redis-py#2086)) * Fix missing ClusterPipeline._lock ([#2189](redis/redis-py#2189)) * Added dynaminc_startup_nodes configuration to RedisCluster * Fix reusing the old nodes' connections when cluster topology refresh is being done * Fix RedisCluster to immediately raise AuthenticationError without a retry * ClusterPipeline Doesn't Handle ConnectionError for Dead Hosts ([#2225](redis/redis-py#2225)) * Remove compatibility code for old versions of Hiredis, drop Packaging dependency * The `deprecated` library is no longer a dependency * Failover handling improvements for RedisCluster and Async RedisCluster ([#2377](redis/redis-py#2377)) * Fixed "cannot pickle '_thread.lock' object" bug ([#2354](redis/redis-py#2354), [#2297](redis/redis-py#2297)) * Added CredentialsProvider class to support password rotation </code></pre> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/redis/redis-py/commit/28cc65c18cc4fb37ef14497c963eb181dba8d25d"><code>28cc65c</code></a> Updating all client licenses to clearly be MIT (<a href="https://redirect.github.com/redis/redis-py/issues/2884">#2884</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/2f679261b7ef0e7372868cacd8ba8721406eb495"><code>2f67926</code></a> Version 5.0.0 (<a href="https://redirect.github.com/redis/redis-py/issues/2874">#2874</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/f121cf29e7d7fb5c85c5915ba5ce10a20826e8c0"><code>f121cf2</code></a> Add support for <code>CLIENT SETINFO</code> (<a href="https://redirect.github.com/redis/redis-py/issues/2857">#2857</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/d5c2d1d42ed9f653d450e6127cb6f673f43fb2d0"><code>d5c2d1d</code></a> Adding support for triggered functions (TFUNCTION) (<a href="https://redirect.github.com/redis/redis-py/issues/2861">#2861</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/b0abd555770bba42c57881b488b5fe5b188f088e"><code>b0abd55</code></a> RESP 3 feature documentation (<a href="https://redirect.github.com/redis/redis-py/issues/2872">#2872</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/a532f89adcd5b790e2811588a2d7c34a79b095d5"><code>a532f89</code></a> Add py.typed in accordance with PEP-561 (<a href="https://redirect.github.com/redis/redis-py/issues/2738">#2738</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/673617d2cbac265c6c8d43280d5e6898df4572b6"><code>673617d</code></a> Bump actions/upload-artifact from 2 to 3 (<a href="https://redirect.github.com/redis/redis-py/issues/2877">#2877</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/0ed807777cfab129904fd72fbada793f21ea0a9c"><code>0ed8077</code></a> Bump pypa/gh-action-pip-audit from 1.0.0 to 1.0.8 (<a href="https://redirect.github.com/redis/redis-py/issues/2879">#2879</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/38c7de617a482c9dd2d40699fbdd7ce44736cae9"><code>38c7de6</code></a> Dependabot label change (<a href="https://redirect.github.com/redis/redis-py/issues/2880">#2880</a>)</li> <li><a href="https://github.com/redis/redis-py/commit/8370c4ac20835002fd1044e1742986072f19289c"><code>8370c4a</code></a> Add a Dependabot config to auto-update GitHub action versions (<a href="https://redirect.github.com/redis/redis-py/issues/2847">#2847</a>)</li> <li>Additional commits viewable in <a href="https://github.com/redis/redis-py/compare/v4.6.0...v5.0.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?Description of change
Fixes Issue #2103:
Raising a BaseException inside a
Connection's send or receive oprations causes adisconnect(). BaseExceptions are commonly used for out of band messages in Python and normally not be expecially acted upon, only be handled at the top-levelSee also: #2356 which focuses on a different aspcect of error handling.