Close a Connection whenever an exception is raised for send_command() #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The api does not allow for a "resume", e.g. on a timeout, because an unknown number of bytes has been sent and an internal send state is not maintained. Therefore, there is no point in keeping the connection open.
kristjanvalur
force-pushed
the
kristjan/send_command_disconnect
branch
from
8825b09
to
e80f72e
Compare
Codecov ReportBase: 92.20% // Head: 92.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2516 +/- ##
=======================================
Coverage 92.20% 92.21%
=======================================
Files 113 113
Lines 29357 29357
=======================================
+ Hits 27070 27072 +2
+ Misses 2287 2285 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Closing this in favour of #2506 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The api does not allow for a "resume", e.g. on a timeout, because an unknown number of bytes has been sent and an internal send state is not maintained. Therefore, there is no point in keeping the connection open.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
The discussion at #2560 pointed out that there is no way an open Connecition after a failed
send_command()call can be useful. This PR therefore closes theConnectionon every exception in that case, thus partially reverts a change made in #2104