Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocBlock] Update docblock contents right in the rule #4999

Merged
merged 16 commits into from Sep 11, 2023
Merged

[DocBlock] Update docblock contents right in the rule #4999

merged 16 commits into from Sep 11, 2023

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Sep 11, 2023 •
edited

Follow up to #4987

@TomasVotruba TomasVotruba changed the title tv narrow abstract 10 [DocBlock] Update docblock contents right in the rule Sep 11, 2023
@TomasVotruba TomasVotruba force-pushed the tv-narrow-abstract-10 branch 8 times, most recently from e378dd0 to 893d665 Compare September 11, 2023 17:49
@TomasVotruba TomasVotruba force-pushed the tv-narrow-abstract-10 branch 2 times, most recently from dc41902 to b2bf4b4 Compare September 11, 2023 18:32
samsonasik
samsonasik reviewed Sep 11, 2023
View reviewed changes
tests/Issues/PartialValueDocblockUpdate/Source/PartialUpdateTestRector.php
@@ -42,6 +48,8 @@ public function refactor(Node $node)
'defaults',
);

$this->docBlockUpdater->updateRefactoredNodeWithPhpDocInfo($node);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @shyim FYI, ref issue and PR:

@samsonasik samsonasik mentioned this pull request Sep 11, 2023
Merged
@samsonasik
Copy link
Member

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit a2f7005 into main Sep 11, 2023
39 checks passed
@samsonasik samsonasik deleted the tv-narrow-abstract-10 branch September 11, 2023 21:28
@samsonasik samsonasik mentioned this pull request Sep 12, 2023
Closed
@TomasVotruba
Copy link
Member Author

Thank you 🥳 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@TomasVotruba @samsonasik @actions-user