Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behavior of NullToStrictStringFuncCallArgRector, AddParamTypeSplFixedArrayRector on importNames() enabled. #8196

Closed
samsonasik opened this issue Sep 11, 2023 · 1 comment
Labels

Comments

@samsonasik
Copy link
Member

Bug Report

Subject Details
Rector version last dev-main
Installed as composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/6988e4b4-0d06-4300-9056-3a3a7ea8c10d

<?php

namespace App;

use PhpParser\Node\Name;
use PhpParser\Node\Stmt\Use_;

final class DemoFile
{
    /**
     * @param Use_[]|\PhpParser\Node\Stmt\GroupUse[] $uses
     */
    public function run(Name $name, array $uses)
    {
        return strtolower($name->getLast());
    }
}

Responsible rules

  • NullToStrictStringFuncCallArgRector

  • AddParamTypeSplFixedArrayRector

Expected Behavior

Only docblock should be changed, cast string on $name->getLast() is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant