Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Renaming] Improve performance of RenameFunctionRector #3699

Merged
merged 1 commit into from Apr 28, 2023
Merged

[Renaming] Improve performance of RenameFunctionRector #3699

merged 1 commit into from Apr 28, 2023

Conversation

samsonasik
Copy link
Member

check virtual node early instead of inside loop.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Member Author

@TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit ea454bb into main Apr 28, 2023
40 checks passed
@samsonasik samsonasik deleted the check-virtual-node-arly branch April 28, 2023 05:45
samsonasik added a commit that referenced this pull request May 8, 2023
@samsonasik
[Renaming] Improve performance of RenameFunctionRector (#3699)
14a112e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm approved these changes

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@samsonasik @staabm