[Renaming] Improve performance of RenameFunctionRector (#3699)

rectorphp · May 8, 2023 · 14a112e · 14a112e
1 parent 3d7e89f
commit 14a112e
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/rules/Renaming/Rector/FuncCall/RenameFunctionRector.php b/rules/Renaming/Rector/FuncCall/RenameFunctionRector.php
@@ -51,17 +51,17 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
+        // not to refactor here
+        $isVirtual = (bool) $node->name->getAttribute(AttributeKey::VIRTUAL_NODE);
+        if ($isVirtual) {
+            return null;
+        }
+
         foreach ($this->oldFunctionToNewFunction as $oldFunction => $newFunction) {
             if (! $this->isName($node, $oldFunction)) {
                 continue;
             }
 
-            // not to refactor here
-            $isVirtual = (bool) $node->name->getAttribute(AttributeKey::VIRTUAL_NODE);
-            if ($isVirtual) {
-                continue;
-            }
-
             $node->name = $this->createName($newFunction);
             return $node;
         }