Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpdoc-parser to ^1.20.3 #3691

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Update phpdoc-parser to ^1.20.3 #3691

merged 2 commits into from
Apr 27, 2023

Conversation

samsonasik
Copy link
Member

@TomasVotruba let's try this to ensure no error :

Call to undefined method                               
         Rector\BetterPhpDocParser\ValueObject\Parser\BetterTokenIterator::getTokens()

if the issue persist, inner dependency probably cause to load old phpdoc-parser.

https://github.com/rectorphp/rector-symfony/actions/runs/4808249189/jobs/8557993664?pr=394#step:5:14

@TomasVotruba
Copy link
Member

I think it's related to this one:
f26a476

@samsonasik
Copy link
Member Author

samsonasik commented Apr 27, 2023

Yesterday is working ok, that change was 5 days ago, test failure like that may due to duplicated fixture

@samsonasik samsonasik self-assigned this Apr 27, 2023
@samsonasik
Copy link
Member Author

@TomasVotruba fixed 🎉

@samsonasik samsonasik merged commit c00475c into main Apr 27, 2023
40 checks passed
@samsonasik samsonasik deleted the update-phpdoc-praser branch April 27, 2023 11:51
@TomasVotruba
Copy link
Member

Thank you 👏

samsonasik added a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants