Improve LocalConstantFinder performance #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
fast-const-finder
branch
from
c26c024
to
5b96c09
Compare
samsonasik
reviewed
Apr 22, 2023
| return null; | ||
| } | ||
| $const = $this->findConstantByName($class, $constatName); |
There was a problem hiding this comment.
this can be moved down to last statement to improve performance
staabm
force-pushed
the
fast-const-finder
branch
from
6cb1de3
to
d975304
Compare
samsonasik
approved these changes
Apr 22, 2023
|
Thank you @staabm |
|
not sure why test randomly crash |
I have no idea either. looks like a bug in php-src or even deeper |
samsonasik
pushed a commit
that referenced
this pull request
May 8, 2023
* Improve LocalConstantFinder performance * simplify * typo * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do cheaper checks first. Similar to #3651