Improve LocalConstantFinder performance

rectorphp · Apr 22, 2023 · 5b96c09 · 5b96c09
1 parent 59720a1
commit 5b96c09
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/PhpParser/NodeFinder/LocalConstantFinder.php b/src/PhpParser/NodeFinder/LocalConstantFinder.php
@@ -28,21 +28,22 @@ public function match(ClassConstFetch $classConstFetch): ?Const_
             return null;
         }
 
-        $constantClassType = $this->nodeTypeResolver->getType($classConstFetch->class);
-        if (! $constantClassType instanceof TypeWithClassName) {
+        $constatName = $this->nodeNameResolver->getName($classConstFetch->name);
+        if ($constatName === null) {
             return null;
         }
+        $const = $this->findConstantByName($class, $constatName);
 
-        if (! $this->nodeNameResolver->isName($class, $constantClassType->getClassName())) {
+        $constantClassType = $this->nodeTypeResolver->getType($classConstFetch->class);
+        if (! $constantClassType instanceof TypeWithClassName) {
             return null;
         }
 
-        $constatName = $this->nodeNameResolver->getName($classConstFetch->name);
-        if ($constatName === null) {
+        if (! $this->nodeNameResolver->isName($class, $constantClassType->getClassName())) {
             return null;
         }
 
-        return $this->findConstantByName($class, $constatName);
+        return $const;
     }
 
     private function findConstantByName(Class_ $class, string $constatName): ?Const_