Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update labeler and codeowner configs for CMake files #15208

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Update labeler and codeowner configs for CMake files #15208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7efb1f8
Update labeler and codeowner configs for CMake files
PointKernel Mar 1, 2024
ae9e7d3
Merge branch 'branch-24.04' into cmake-labeler-codeowner
PointKernel Mar 4, 2024
522b7a6
Merge branch 'branch-24.04' into cmake-labeler-codeowner
PointKernel Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ python/dask_cudf/ @rapidsai/cudf-dask-codeowners
cpp/CMakeLists.txt @rapidsai/cudf-cmake-codeowners
cpp/libcudf_kafka/CMakeLists.txt @rapidsai/cudf-cmake-codeowners
**/cmake/ @rapidsai/cudf-cmake-codeowners
*.cmake @rapidsai/cudf-cmake-codeowners
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of declaring cmake codeowner for all files with .cmake extension, we can also explicitly specify the missing file like rapids_config.cmake. I think the former provides more flexibility since we may often add/delete files or moving them around.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. The main thing we've explicitly avoided is requiring CMake codeowner review for the test and benchmarks CMakeLists.txt files because most changes in those files are just adding a new file to compile and that shouldn't be blocked on a CMake review.


#java code owners
java/ @rapidsai/cudf-java-codeowners
Expand Down
1 change: 1 addition & 0 deletions .github/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ libcudf:
CMake:
- '**/CMakeLists.txt'
- '**/cmake/**'
- '**/*.cmake'

cuDF (Java):
- 'java/**'
Expand Down