Update labeler and codeowner configs for CMake files #15208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
approved these changes
Mar 1, 2024
PointKernel
commented
Mar 1, 2024
| @@ -11,6 +11,7 @@ python/dask_cudf/ @rapidsai/cudf-dask-codeowners | |||
| cpp/CMakeLists.txt @rapidsai/cudf-cmake-codeowners | |||
| cpp/libcudf_kafka/CMakeLists.txt @rapidsai/cudf-cmake-codeowners | |||
| **/cmake/ @rapidsai/cudf-cmake-codeowners | |||
| *.cmake @rapidsai/cudf-cmake-codeowners | |||
There was a problem hiding this comment.
Instead of declaring cmake codeowner for all files with .cmake extension, we can also explicitly specify the missing file like rapids_config.cmake. I think the former provides more flexibility since we may often add/delete files or moving them around.
There was a problem hiding this comment.
I think this is fine. The main thing we've explicitly avoided is requiring CMake codeowner review for the test and benchmarks CMakeLists.txt files because most changes in those files are just adding a new file to compile and that shouldn't be blocked on a CMake review.
raydouglass
approved these changes
Mar 4, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When working on #15206, I noticed the
rapids_config.cmakefile was not properly labeled. Based on offline discussions, we also noticed that the file's codeowner was misconfigured as well.This PR updates both github
labelerandCODEOWNERfiles to properly handle files with.cmakeextension.Checklist