Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce Transport.ConnContext, use client's context on the connection #4507

Merged
merged 2 commits into from
May 27, 2024

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented May 13, 2024

For #4422.

TODO:

  • add documentation for quic-go.net

This will allow us to remote the ConnectionTracingID.

@marten-seemann marten-seemann force-pushed the conn-context branch 3 times, most recently from 3a97425 to 60d4e96 Compare May 13, 2024 05:44
@marten-seemann marten-seemann added this to the v0.44 milestone May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 85.12%. Comparing base (e2fbf3c) to head (3df5170).

Files Patch % Lines
server.go 54.55% 4 Missing and 1 partial ⚠️
connection.go 66.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4507      +/-   ##
==========================================
- Coverage   85.15%   85.12%   -0.03%     
==========================================
  Files         154      154              
  Lines       14794    14803       +9     
==========================================
+ Hits        12597    12600       +3     
- Misses       1690     1694       +4     
- Partials      507      509       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann
Copy link
Member Author

Added another test to the integration test: previously, the context on tls.Config.GetCertificate was not tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants