Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http3: use the connection, not the stream context, on the server side #4510

Merged
merged 1 commit into from
Jun 3, 2024
Merged

http3: use the connection, not the stream context, on the server side #4510

merged 1 commit into from
Jun 3, 2024

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented May 13, 2024 •
edited

Depends on #4507. Fixes #4422.

@marten-seemann marten-seemann mentioned this pull request May 13, 2024
Closed
@marten-seemann marten-seemann changed the base branch from conn-context to master June 1, 2024 04:04
@marten-seemann marten-seemann linked an issue Jun 2, 2024 that may be closed by this pull request
add a ConnContext to the quic.Config, remove it from the http3.Server #4422
Closed
@marten-seemann marten-seemann linked an issue Jun 2, 2024 that may be closed by this pull request
http3: request context cancellation #4508
Closed
@codecov Codecov
Copy link

codecov bot commented Jun 2, 2024 •
edited

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.18%. Comparing base (82a3847) to head (d8fe4c0).
Report is 1 commits behind head on master.

Files Patch % Lines
http3/server.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4510      +/-   ##
==========================================
+ Coverage   85.12%   85.18%   +0.05%     
==========================================
  Files         154      154              
  Lines       14802    14828      +26     
==========================================
+ Hits        12600    12630      +30     
+ Misses       1694     1689       -5     
- Partials      508      509       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rthellend
rthellend approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@rthellend rthellend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marten-seemann
Copy link
Member Author

Thanks for reviewing @rthellend!

@marten-seemann marten-seemann merged commit 5446b5f into master Jun 3, 2024
34 checks passed
@marten-seemann marten-seemann deleted the http3-use-conn-context branch June 3, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rthellend rthellend rthellend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http3: request context cancellation add a ConnContext to the quic.Config, remove it from the http3.Server
2 participants
@marten-seemann @rthellend