handshake: clone the tls.Config returned by GetConfigForClient #4133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
dont-modify-getconfigforclient-config
branch
from
f690b26
to
85b8e39
Compare
Codecov Report
@@ Coverage Diff @@
## master #4133 +/- ##
==========================================
+ Coverage 83.73% 83.75% +0.02%
==========================================
Files 150 150
Lines 15429 15430 +1
==========================================
+ Hits 12918 12922 +4
+ Misses 2012 2010 -2
+ Partials 499 498 -1
|
We modify this tls.Config, so we shouldn't modify it. This could cause conflicts with how the application is using that config.
marten-seemann
force-pushed
the
dont-modify-getconfigforclient-config
branch
from
85b8e39
to
acbefb2
Compare
sukunrt
approved these changes
Oct 27, 2023
marten-seemann
added a commit
that referenced
this pull request
Oct 27, 2023
We modify this tls.Config, so we should clone it first. Otherwise, this could cause conflicts with how the application is using that config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4132.
We modify this
tls.Config, so we should clone it first. Otherwise, this could cause conflicts with how the application is using that config.