handshake: set MinVersion on the Config returned by GetConfigForClient #4134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4134 +/- ##
==========================================
+ Coverage 83.75% 83.77% +0.02%
==========================================
Files 150 150
Lines 15430 15432 +2
==========================================
+ Hits 12922 12927 +5
+ Misses 2010 2007 -3
Partials 498 498
|
marten-seemann
force-pushed
the
dont-modify-getconfigforclient-config
branch
from
85b8e39
to
acbefb2
Compare
sukunrt
approved these changes
Oct 27, 2023
marten-seemann
changed the base branch from
dont-modify-getconfigforclient-config
to
master
marten-seemann
force-pushed
the
getconfigforclient-minversion
branch
from
f690b26
to
24f5f52
Compare
marten-seemann
added a commit
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4133. Fixes #4131.